diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 2eca70f..5aecdaf 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -31,17 +31,26 @@ jobs: pdm export -f requirements --without-hashes --dev > requirements.txt python3.12 -m pip install -r requirements.txt - - name: Build + - name: Build binary release run: | python3.12 -m nuitka --standalone --onefile --output-filename=ldeep.bin ldeep/__main__.py mv ldeep.bin ldeep_linux-amd64 - - name: Upload Artifacts + - name: Build Source Distribution + run: pdm build -d sdist --no-wheel + + - name: Upload Artifacts (binary) uses: actions/upload-artifact@v3 with: name: linux path: ldeep_linux-amd64 + - name: Upload Artifacts (sdist) + uses: actions/upload-artifact@v3 + with: + name: sdist + path: sdist/* + windows-build: name: Windows Build runs-on: "windows-latest" diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index f649630..4a33810 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -17,9 +17,6 @@ jobs: - name: Get local version run: echo "version=$(cat VERSION)" >> $GITHUB_ENV - - name: Build sdist - run: pdm build -d sdist --no-wheel - - name: Create tag uses: rickstaa/action-create-tag@v1 with: diff --git a/VERSION b/VERSION index 78a3e6e..ed453e6 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -1.0.55 +1.0.56 diff --git a/ldeep/views/ldap_activedirectory.py b/ldeep/views/ldap_activedirectory.py index 07123d3..9795d60 100644 --- a/ldeep/views/ldap_activedirectory.py +++ b/ldeep/views/ldap_activedirectory.py @@ -698,7 +698,6 @@ def get_gmsa(self, attributes): sam = entry["sAMAccountName"] data = entry["msDS-ManagedPassword"] readers = entry["msDS-GroupMSAMembership"] - # Find principals who can read the password try: readers_sd = parse_ntSecurityDescriptor(readers) @@ -717,7 +716,6 @@ def get_gmsa(self, attributes): pass except Exception: pass - blob = MSDS_MANAGEDPASSWORD_BLOB() try: blob.fromString(data)