From 61b77cef75b888774287839f84fab74f122706f6 Mon Sep 17 00:00:00 2001
From: Francisco Salgueiro <fgcdbs@gmail.com>
Date: Sat, 9 Dec 2023 19:16:14 +0000
Subject: [PATCH] disallow selecting null value in required select inputs

---
 src/components/boards/BoardGame.tsx           |  1 +
 src/components/common/GameInfo.tsx            |  1 +
 src/components/home/Accounts.tsx              |  5 +++-
 .../panels/analysis/EngineSettingsForm.tsx    |  1 +
 src/components/panels/analysis/LogsPanel.tsx  |  3 ++-
 .../panels/analysis/ReportModal.tsx           |  2 ++
 src/components/panels/info/FenInput.tsx       |  1 +
 src/components/panels/info/RepertoireInfo.tsx |  1 +
 src/components/settings/SettingsSelect.tsx    | 27 ++++++++++---------
 src/components/tabs/ImportModal.tsx           |  1 +
 10 files changed, 29 insertions(+), 14 deletions(-)

diff --git a/src/components/boards/BoardGame.tsx b/src/components/boards/BoardGame.tsx
index a61662b7..0026e7b6 100644
--- a/src/components/boards/BoardGame.tsx
+++ b/src/components/boards/BoardGame.tsx
@@ -75,6 +75,7 @@ function EnginesSelect({
     <Suspense>
       <Select
         label="Engine"
+        allowDeselect={false}
         data={engines!.map((engine) => ({
           label: engine.name,
           value: engine.path,
diff --git a/src/components/common/GameInfo.tsx b/src/components/common/GameInfo.tsx
index 16de6668..ce77280e 100644
--- a/src/components/common/GameInfo.tsx
+++ b/src/components/common/GameInfo.tsx
@@ -214,6 +214,7 @@ function GameInfo({
           />
           <Select
             readOnly={disabled}
+            allowDeselect={false}
             data={["1-0", "0-1", "1/2-1/2", "*"]}
             value={headers.result}
             variant="unstyled"
diff --git a/src/components/home/Accounts.tsx b/src/components/home/Accounts.tsx
index 59ee313a..a4c72049 100644
--- a/src/components/home/Accounts.tsx
+++ b/src/components/home/Accounts.tsx
@@ -70,7 +70,9 @@ function Accounts() {
           <AccountCards databases={databases} setDatabases={setDatabases} />
         </Stack>
       </ScrollArea>
-      <Button h="2.5rem" onClick={() => setOpen(true)}>Add Account</Button>
+      <Button h="2.5rem" onClick={() => setOpen(true)}>
+        Add Account
+      </Button>
       <AccountModal
         open={open}
         setOpen={setOpen}
@@ -125,6 +127,7 @@ function AccountModal({
       >
         <Stack>
           <Select
+            allowDeselect={false}
             label="Website"
             placeholder="Select website"
             data={[
diff --git a/src/components/panels/analysis/EngineSettingsForm.tsx b/src/components/panels/analysis/EngineSettingsForm.tsx
index 0b8dcce3..ced88ec4 100644
--- a/src/components/panels/analysis/EngineSettingsForm.tsx
+++ b/src/components/panels/analysis/EngineSettingsForm.tsx
@@ -257,6 +257,7 @@ function AdvancedOptions({
           <Table.Tr>
             <Table.Td>
               <Select
+                allowDeselect={false}
                 variant="unstyled"
                 comboboxProps={{
                   position: "bottom",
diff --git a/src/components/panels/analysis/LogsPanel.tsx b/src/components/panels/analysis/LogsPanel.tsx
index 415fd805..8f28ffb6 100644
--- a/src/components/panels/analysis/LogsPanel.tsx
+++ b/src/components/panels/analysis/LogsPanel.tsx
@@ -91,11 +91,12 @@ export default function LogsPanel() {
           ]}
         />
         <Select
+          allowDeselect={false}
           value={engine?.name ?? "No engines loaded"}
           onChange={(name) =>
             setEngine(localEngines.find((e) => e.name === name))
           }
-          data={engines.map((e) => ({ value: e.name, label: e.name }))}
+          data={localEngines.map((e) => ({ value: e.name, label: e.name }))}
         />
       </Group>
 
diff --git a/src/components/panels/analysis/ReportModal.tsx b/src/components/panels/analysis/ReportModal.tsx
index 734ece7d..331b3455 100644
--- a/src/components/panels/analysis/ReportModal.tsx
+++ b/src/components/panels/analysis/ReportModal.tsx
@@ -84,6 +84,7 @@ function ReportModal({
       <form onSubmit={form.onSubmit(() => analyze())}>
         <Stack>
           <Select
+            allowDeselect={false}
             withAsterisk
             label="Engine"
             placeholder="Pick one"
@@ -99,6 +100,7 @@ function ReportModal({
           />
           <Group wrap="nowrap">
             <Select
+              allowDeselect={false}
               comboboxProps={{
                 position: "bottom",
                 middlewares: { flip: false, shift: false },
diff --git a/src/components/panels/info/FenInput.tsx b/src/components/panels/info/FenInput.tsx
index d6716ec5..c631ec65 100644
--- a/src/components/panels/info/FenInput.tsx
+++ b/src/components/panels/info/FenInput.tsx
@@ -56,6 +56,7 @@ function FenInput({ currentFen }: { currentFen: string }) {
           <Text fw="bold">FEN</Text>
           <FenSearch currentFen={currentFen} />
           <Select
+            allowDeselect={false}
             data={[
               { label: "White to move", value: "white" },
               { label: "Black to move", value: "black" },
diff --git a/src/components/panels/info/RepertoireInfo.tsx b/src/components/panels/info/RepertoireInfo.tsx
index e3954e8a..a2d04a19 100644
--- a/src/components/panels/info/RepertoireInfo.tsx
+++ b/src/components/panels/info/RepertoireInfo.tsx
@@ -59,6 +59,7 @@ function RepertoireInfo() {
         <Text>opening for</Text>
 
         <Select
+          allowDeselect={false}
           value={headers.orientation || "white"}
           variant="unstyled"
           rightSection={<></>}
diff --git a/src/components/settings/SettingsSelect.tsx b/src/components/settings/SettingsSelect.tsx
index 187b666a..dd5cf6a1 100644
--- a/src/components/settings/SettingsSelect.tsx
+++ b/src/components/settings/SettingsSelect.tsx
@@ -2,19 +2,22 @@ import { Select } from "@mantine/core";
 import { PrimitiveAtom, useAtom } from "jotai";
 
 export default function SettingsSelect({
-    atom,
-    data,
-    placeholder,
+  atom,
+  data,
+  placeholder,
 }: {
-    atom: PrimitiveAtom<string>;
-    data: { label: string; value: string }[];
-    placeholder: string;
+  atom: PrimitiveAtom<string>;
+  data: { label: string; value: string }[];
+  placeholder: string;
 }) {
-    const [value, setValue] = useAtom(atom);
-    return <Select
-        data={data}
-        value={value}
-        onChange={(v) => setValue(v!)}
-        placeholder={placeholder}
+  const [value, setValue] = useAtom(atom);
+  return (
+    <Select
+      allowDeselect={false}
+      data={data}
+      value={value}
+      onChange={(v) => setValue(v!)}
+      placeholder={placeholder}
     />
+  );
 }
diff --git a/src/components/tabs/ImportModal.tsx b/src/components/tabs/ImportModal.tsx
index cd8ff494..692c239d 100644
--- a/src/components/tabs/ImportModal.tsx
+++ b/src/components/tabs/ImportModal.tsx
@@ -105,6 +105,7 @@ export default function ImportModal({
       title="Import game"
     >
       <Select
+        allowDeselect={false}
         label="Type of import"
         placeholder="Pick one"
         mb="lg"