Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require message #6

Closed
pkristian opened this issue Jul 29, 2018 · 6 comments
Closed

Do not require message #6

pkristian opened this issue Jul 29, 2018 · 6 comments
Labels
enhancement New feature or request

Comments

@pkristian
Copy link
Collaborator

it would be cool, if message will not be required.

@franiglesias
Copy link
Owner

I'll look into it. I've had problems trying to tag without message (the script failed).

@pkristian
Copy link
Collaborator Author

the problem is, that you after major|minor|patch you expect message.
since this package is new, i will suggest BC break: versiontag major -m|--message "message"
same like in git commit

@franiglesias
Copy link
Owner

The problem happened when the script tried to execute git tag without message. It failed when opening editor to add message. I've not looked yet how to tag with no message, so I force a message to be passed. I'm agree with the BC break. I'll take a look this night :-).

@pkristian
Copy link
Collaborator Author

i looked in docu: https://git-scm.com/docs/git-tag

it looks like it is problem with git tag -a which looks like require message
but unannotated tags are ignored by git describle, so what about to change to git tag --list for getting last tag?

@franiglesias
Copy link
Owner

franiglesias commented Jul 30, 2018

I'm looking into that, but see issue #4 to discuss about the source of truth about versioning. Having the .semver file, I'm considering to use it instead of git tags (or have some kind of check to verify them. Not sure about that). This also resolve the unannotated tags issue.

By the other hand, git tag --list has the problem that could be difficult to know which is the last tag.

@franiglesias franiglesias added the enhancement New feature or request label Jul 31, 2018
@franiglesias
Copy link
Owner

I want to merge some fixes before implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants