fix: limit connections a worker can accept at any time #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nthreads
requests at any time i.e. 2-6 in our deployments.502
error.Fix:
n+1
wheren
is number of threads.n+1
avoids serial chain ofaccept
->threadpool
and ensures better threadpool utilization.Note: diff says +2 because there's an off by one error in gunicorn logic, that doesn't matter much, we just need to avoid accepting huge number of requests +1 or +2 are both fine)
Things I verified:
ping
i.e. threadpool utilization is just fine.n+1