Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Translation plugin #232

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: Translation plugin #232

wants to merge 5 commits into from

Conversation

shariquerik
Copy link
Member

@shariquerik shariquerik commented Dec 2, 2024 •
edited
Loading 

import { translationPlugin } from 'frappe-ui'
app.use(translationPlugin)

Examples

__('Hello')
__('{0} of {1}', [3, 100])

fixes: #233
dependent on: frappe/frappe#28638

@netlify Netlify
Copy link

netlify bot commented Dec 2, 2024 •
edited
Loading

✅ Deploy Preview for frappeui ready!

Name Link
🔨 Latest commit 0a4bfdf
🔍 Latest deploy log https://app.netlify.com/sites/frappeui/deploys/674da5f1a54a3f00086ac06b
😎 Deploy Preview https://deploy-preview-232--frappeui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shariquerik shariquerik mentioned this pull request Dec 2, 2024
Merged
@shariquerik shariquerik mentioned this pull request Dec 2, 2024
Draft
@shariquerik shariquerik marked this pull request as draft December 2, 2024 12:27
@shariquerik shariquerik marked this pull request as ready for review December 2, 2024 13:43
This was referenced Dec 2, 2024
Merged
Merged
@shariquerik shariquerik marked this pull request as draft December 3, 2024 07:53
@netchampfaris
Copy link
Contributor

This PR is incomplete without an accompanying python package, because it depends on translated strings to be set on window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pateljannat pateljannat pateljannat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translation plugin
3 participants
@shariquerik @netchampfaris @pateljannat