Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post the non-minified version / source to let community submit new features #35

Open
steve-ross opened this issue Aug 31, 2016 · 3 comments

Comments

@steve-ross
Copy link

Can you post the source for this project so people can submit PRs?

@MisinformedDNA
Copy link

@freakdesign Is there a plan to do this?

@freakdesign
Copy link
Owner

@MisinformedDNA
The code is going to need a decent rewrite shortly so would have some concerns about doing that at this stage. Whatever is released will change, potentially drastically.

Certainly would consider it if the desire from others is really there but would prefer to just make a brand new repo of the general framework so others can roll their own.

It needs some thought.

@DaveLak
Copy link

DaveLak commented Jul 21, 2018

The code is going to need a decent rewrite shortly so would have some concerns about doing that at this stage.

If you're hesitant to add the un-minified code to this repo maybe post it as a Gist and link it in the README or Wiki? I've only just come across this repo and as exciting as I think it is, I'm hesitant to install an extension or bookmarklet that pulls executable code from GitHub or Amazon S3 with the intention of executing it in the admin context of any website.

Whatever is released will change, potentially drastically. [...] would prefer to just make a brand new repo of the general framework

I, and I'm sure others, would love to see such a repo. It would allow for higher quality more feedback and/or contributions if nothing else but would that make it any less valuable to release this code un-minified? Perhaps I'm failing to see something, if so please let me know, but I feel adding the un-obfuscated code to the repo now would be both useful immediately and interesting historically.

so others can roll their own

I think the ability to easily audit, copy, and run the code from a locally cached source is especially important considering it's executing in an admin interface on an e-commerce platform.

That said, thanks for your work! This is very cool and the missing piece of the Shopify admin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants