Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Value Should Wipe Exisiting Value #37

Open
chryton opened this issue Nov 29, 2016 · 5 comments
Open

Empty Value Should Wipe Exisiting Value #37

chryton opened this issue Nov 29, 2016 · 5 comments

Comments

@chryton
Copy link
Contributor

chryton commented Nov 29, 2016

Been noticing that if I need to turn something "off" by removing a value from a field (such as making a text input empty) that does not save or remove the metafield.

The only way to do this would be to go into FD and remove the generated metafield.

This is overall slightly confusing user experience as why should a user have to use another too to just reset/remove a value from a field and leave that field blank?

@chryton chryton changed the title Empty Value Should Wipe Value Empty Value Should Wipe Exisiting Value Nov 29, 2016
@freakdesign
Copy link
Owner

Thanks for the heads up.

I always thought that blanking the field did remove it, but it's possible that's all a dream. I wasn't planning on adding many more mods to this version, but this seems like a valid thing to add now.

@chryton
Copy link
Contributor Author

chryton commented May 25, 2017

@freakdesign Just checking in to see if this has been investigated at all. Still running into the issue on stores.

If there was unminified/source code, I or someone on my team could help debug the issue and submit a PR.

@freakdesign
Copy link
Owner

I tested this (briefly) and didn't see the same result. I followed these steps:

  • created a metafield on a collection using the extension
  • reloaded the collection (and ran the tool again)
  • double checked the metafield existed with ShopifyFD
  • cleared the field value in Custom Fields and saved
  • reloaded the collection (and ran the tool)
  • The field was empty and ShopifyFD reported no metafield.

I'd be curious to see if you still see this problem and what steps you take.

@chryton
Copy link
Contributor Author

chryton commented Jun 9, 2017

Here is a screencast of what I am seeing on a test store: http://i.rocktc.de/tYAJET/31XiRHn2

@freakdesign
Copy link
Owner

That's most curious. I don't get the same result at all. Let's take a quick peek at your network logs and see what actions are actually firing. In your video there should be a metafield delete call being made. If not, or if it returns some error - that will help give me some starting clues to replicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants