From dc35c85acf8e1489d213f98dbaf58de56d83fda2 Mon Sep 17 00:00:00 2001 From: Fredy Wijaya Date: Wed, 2 Oct 2024 16:12:05 -0500 Subject: [PATCH] mobile: Mark AndroidEngineExplicitFlowTest as flaky (#36426) The `AndroidEngineExplicitFlowTest.post_multipleRequests_randomBehavior` seems to be the one that's causing the flakiness. Adding `flaky = True` and fixing the HTTP method to `POST` as what the test is intended seemed to reduce the flakiness. Risk Level: low (test only) Testing: `bazel test --runs_per_test=100 //test/java/integration:android_engine_explicit_flow_test` Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a Signed-off-by: Fredy Wijaya --- .../test/java/integration/AndroidEngineExplicitFlowTest.java | 4 ++-- mobile/test/java/integration/BUILD | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/mobile/test/java/integration/AndroidEngineExplicitFlowTest.java b/mobile/test/java/integration/AndroidEngineExplicitFlowTest.java index e6e19862933a..b29cbce25659 100644 --- a/mobile/test/java/integration/AndroidEngineExplicitFlowTest.java +++ b/mobile/test/java/integration/AndroidEngineExplicitFlowTest.java @@ -481,8 +481,8 @@ public void post_multipleRequests_randomBehavior() throws Exception { mockWebServer.enqueue(new MockResponse().setBody("hello, world")); RequestScenario requestScenario = new RequestScenario() - .setHttpMethod(RequestMethod.GET) - .setUrl(mockWebServer.url("get/flowers").toString()) + .setHttpMethod(RequestMethod.POST) + .setUrl(mockWebServer.url("post/flowers").toString()) .addBody("This is my body part 1") .addBody("This is my body part 2") .setResponseBufferSize(20); // Larger than the response body size diff --git a/mobile/test/java/integration/BUILD b/mobile/test/java/integration/BUILD index 7154488b71c0..e987ab645602 100644 --- a/mobile/test/java/integration/BUILD +++ b/mobile/test/java/integration/BUILD @@ -51,6 +51,7 @@ envoy_mobile_android_test( srcs = [ "AndroidEngineExplicitFlowTest.java", ], + flaky = True, native_deps = [ "//test/jni:libenvoy_jni_with_test_extensions.so", ] + select({