-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webinterface tables are hard to read due to background color #1114
Labels
Comments
ohaucke
changed the title
Webinterface tables are almost unreadable due to background color
Webinterface tables are hard to read due to background color
Jan 25, 2024
master has since moved on to an overhauled look, but 3.4.1 suffers from this garish look. I think the right fix is to just limit the colouring in poudriere.css to the thead child. Will post a patch for release-3.4, which we should push through to ports, including the quarterly branch. |
jrtc27
added a commit
to jrtc27/poudriere
that referenced
this issue
Jun 18, 2024
…ables The newer DataTables imported in ce2146e ("Update DataTables to 1.13.8") started setting every other row to transparent. Since we add the built etc classes to the whole table, this means the entire table's background colour is green etc, and so the transparent rows now allow that colour to shine through, making it hard to read the text. Adapt the CSS selectors to only colour the thead within the whole table so that the rows are restored to being uncoloured, less garish and rather more readable. Note that these classes are also used for the status display at the top, so we need to handle them on things other than tables too, where we continue to just colour the whole element. Fixes freebsd#1114 Fixes: ce2146e ("Update DataTables to 1.13.8")
jrtc27
added a commit
to jrtc27/poudriere
that referenced
this issue
Jun 18, 2024
…ables The newer DataTables imported in ce2146e ("Update DataTables to 1.13.8") started setting every other row to transparent. Since we add the built etc classes to the whole table, this means the entire table's background colour is green etc, and so the transparent rows now allow that colour to shine through, making it hard to read the text. Adapt the CSS selectors to only colour the thead within the whole table so that the rows are restored to being uncoloured, less garish and rather more readable. Note that these classes are also used for the status display at the top, so we need to handle them on things other than tables too, where we continue to just colour the whole element. Fixes freebsd#1114 Fixes: ce2146e ("Update DataTables to 1.13.8")
Fixed in d2cb250 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Describe the bug
The current color scheme (
even
rows) for tables makes it really hard to readbuild
/failed
/skipped
/fetched
andqueued
.How to reproduce
Steps to reproduce the behavior:
Expected behavior
Don't set the css
background-color
foreven
rows totransparent
Screenshots
Environment
13.2 amd64
13.2 amd64
Firefox
&Chrome
3.4.1
latest
The text was updated successfully, but these errors were encountered: