From b542668362ec6398002429468ff3efca8d8bb85b Mon Sep 17 00:00:00 2001
From: Alex Pyrgiotis <alex.p@freedom.press>
Date: Mon, 2 Dec 2024 18:12:16 +0200
Subject: [PATCH] Move container-specific method from base class

Move the `is_runtime_available()` method from the base
`IsolationProvider` class, and into the `Dummy` provider class. This
method was originally defined in the base class, in order to be mocked
in our tests for the `Dummy` provider. There's no reason for the `Qubes`
class to have it though, so we can just move it to the `Dummy` provider.
---
 dangerzone/gui/main_window.py          | 1 +
 dangerzone/isolation_provider/base.py  | 4 ----
 dangerzone/isolation_provider/dummy.py | 4 ++++
 3 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/dangerzone/gui/main_window.py b/dangerzone/gui/main_window.py
index e292ff0b5..788ad6abb 100644
--- a/dangerzone/gui/main_window.py
+++ b/dangerzone/gui/main_window.py
@@ -500,6 +500,7 @@ def check_state(self) -> None:
         error: Optional[str] = None
 
         try:
+            assert isinstance(self.dangerzone.isolation_provider, (Dummy, Container))
             self.dangerzone.isolation_provider.is_runtime_available()
         except NoContainerTechException as e:
             log.error(str(e))
diff --git a/dangerzone/isolation_provider/base.py b/dangerzone/isolation_provider/base.py
index 6a55a20f1..9404cee25 100644
--- a/dangerzone/isolation_provider/base.py
+++ b/dangerzone/isolation_provider/base.py
@@ -93,10 +93,6 @@ def __init__(self) -> None:
         else:
             self.proc_stderr = subprocess.DEVNULL
 
-    @staticmethod
-    def is_runtime_available() -> bool:
-        return True
-
     @abstractmethod
     def install(self) -> bool:
         pass
diff --git a/dangerzone/isolation_provider/dummy.py b/dangerzone/isolation_provider/dummy.py
index 9ebc345fa..b8e3b879e 100644
--- a/dangerzone/isolation_provider/dummy.py
+++ b/dangerzone/isolation_provider/dummy.py
@@ -39,6 +39,10 @@ def __init__(self) -> None:
     def install(self) -> bool:
         return True
 
+    @staticmethod
+    def is_runtime_available() -> bool:
+        return True
+
     def start_doc_to_pixels_proc(self, document: Document) -> subprocess.Popen:
         cmd = [
             sys.executable,