-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not maintain multiple image IDs #1020
Labels
enhancement
New feature or request
Comments
apyrgio
added a commit
that referenced
this issue
Dec 2, 2024
Revamp the container image installation process in a way that does not involve using image IDs. We don't want to rely on image IDs anymore, since they are brittle (see #933). Instead, we use image tags, as provided in the `image-id.txt` file. This allows us to check fast if an image is up to date, and we no longer need to maintain multiple image IDs from various container runtimes. Refs #933 Refs #988 Fixes #1020
apyrgio
added a commit
that referenced
this issue
Dec 2, 2024
Revamp the container image installation process in a way that does not involve using image IDs. We don't want to rely on image IDs anymore, since they are brittle (see #933). Instead, we use image tags, as provided in the `image-id.txt` file. This allows us to check fast if an image is up to date, and we no longer need to maintain multiple image IDs from various container runtimes. Refs #933 Refs #988 Fixes #1020
apyrgio
added a commit
that referenced
this issue
Dec 2, 2024
Revamp the container image installation process in a way that does not involve using image IDs. We don't want to rely on image IDs anymore, since they are brittle (see #933). Instead, we use image tags, as provided in the `image-id.txt` file. This allows us to check fast if an image is up to date, and we no longer need to maintain multiple image IDs from various container runtimes. Refs #933 Refs #988 Fixes #1020
apyrgio
added a commit
that referenced
this issue
Dec 2, 2024
Revamp the container image installation process in a way that does not involve using image IDs. We don't want to rely on image IDs anymore, since they are brittle (see #933). Instead, we use image tags, as provided in the `image-id.txt` file. This allows us to check fast if an image is up to date, and we no longer need to maintain multiple image IDs from various container runtimes. Refs #933 Refs #988 Fixes #1020
apyrgio
added a commit
that referenced
this issue
Dec 2, 2024
Revamp the container image installation process in a way that does not involve using image IDs. We don't want to rely on image IDs anymore, since they are brittle (see #933). Instead, we use image tags, as provided in the `image-id.txt` file. This allows us to check fast if an image is up to date, and we no longer need to maintain multiple image IDs from various container runtimes. Refs #933 Refs #988 Fixes #1020
apyrgio
added a commit
that referenced
this issue
Dec 4, 2024
Revamp the container image installation process in a way that does not involve using image IDs. We don't want to rely on image IDs anymore, since they are brittle (see #933). Instead, we use image tags, as provided in the `image-id.txt` file. This allows us to check fast if an image is up to date, and we no longer need to maintain multiple image IDs from various container runtimes. Refs #933 Refs #988 Fixes #1020
apyrgio
added a commit
that referenced
this issue
Dec 9, 2024
Revamp the container image installation process in a way that does not involve using image IDs. We don't want to rely on image IDs anymore, since they are brittle (see #933). Instead, we use image tags, as provided in the `image-id.txt` file. This allows us to check fast if an image is up to date, and we no longer need to maintain multiple image IDs from various container runtimes. Refs #933 Refs #988 Fixes #1020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, Dangerzone ships with two files in its
share/
directory that are not part of this repo:share/container.tar.gz
, which is the image tarball that accompanies every new Dangerzone release.share/image-id.txt
, which is a file that holds all the image IDs that match the contents of this tarball.The purpose of the image ID file is to specify what is the expected image ID in the local Podman/Docker installation. If not found, Dangerzone will load the image tarball, which takes a while. The problem with image IDs though is that they have stopped being reliable, now that Docker has introduced its own containerd image store (see #933). For this reason, as part of the release we have to get two image IDs, one for the regular image store that Docker and Podman use, and one for the containerd image store. This is a pain for several reasons:
image-id.txt
file with just one image ID.For this reason, it would be best to use a different type of image ID, such as image tags. We can tag our Dangerzone images with a unique tag, include it in the
image-id.txt
file, and look for the required tag indocker images
/podman images
, which we already do. This change should not affect the developer's and user's workflow, but it will improve the release situation a lot.The text was updated successfully, but these errors were encountered: