Non stateful commands used to install templates

[ben-grande]

• I have searched for duplicates or related issues

Description

Related:

• Provision-all error when Fedora-35 template already installed  #797

There are some places that I found that shell commands were used when salt modules already exist.

• qvm.template_installed
• Not sure about the rpm module, but don't use sudo even in dom0, prefer runas: root
• qvm.template_installed
• qvm.shutdown and qmv.prefs
• shell command qubes-vm-update doesn't use salt and is faster

Steps to Reproduce

Not applicable.

Expected Behavior

Stateful commands.

Actual Behavior

Non stateful commands used.

[kennethrrosen]

I'd be happy to take this on with a little guidance, if of interest to the team.

[ben-grande]

@kennethrrosen If you are still interested in doing it, please specify what you did not understand.

One task example: change the use of cmd.run of qvm-template to qvm.template_installed. The other tasks are very similar. There may be others in the repo, I just listed some above that were specifically linked to the templates installation.

[kennethrrosen]

@ben-grande I understood everything without issue, and plan on taking this on -- if, and only if, this is something @rocodes approves of.