Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the checkbox inputs inside a fieldset with <legend> #887

Open
SaptakS opened this issue Aug 18, 2021 · 3 comments
Open

Put the checkbox inputs inside a fieldset with <legend> #887

SaptakS opened this issue Aug 18, 2021 · 3 comments

Comments

@SaptakS
Copy link
Contributor

SaptakS commented Aug 18, 2021

Put the checkbox inputs inside a fieldset with <legend> describing the input options in https://securedrop.org/directory/submit/

@SaptakS SaptakS changed the title Put the checkbox inputs inside a fieldset with <legend> describing the input options in https://securedrop.org/directory/submit/ Put the checkbox inputs inside a fieldset with <legend> Aug 18, 2021
@SaptakS
Copy link
Contributor Author

SaptakS commented Aug 18, 2021

#865 (comment)

The third item on this list I think is ultimately coming from within Django. The wagtail form builder relies on Django to render checkbox list form fields and these are done without proper grouping tags.

Looks like it might be being worked on, though?

@soleilera
Copy link

@SaptakS I believe this was fixed: https://code.djangoproject.com/ticket/32338

@SaptakS
Copy link
Contributor Author

SaptakS commented Oct 5, 2023

It has been added in some capacity in Django 4.1, but we are still using Django 3.2. So till we update to the next LTS, I think maybe we should keep this issue open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants