Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bigger version of the InlineSpinner #443

Open
nlopin opened this issue Apr 19, 2024 · 0 comments
Open

Bigger version of the InlineSpinner #443

nlopin opened this issue Apr 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@nlopin
Copy link
Contributor

nlopin commented Apr 19, 2024

Describe the feature you'd like

The current version of the spinner has two sizes - small and medium.

We should have a bigger variant so the spinner can be used on a bigger card while the data is loading.
It could have the following style:

width: 2rem;
height: 2rem;
border-width: .175rem;

Describe alternatives you've considered

The alternative to an extra size is to allow the user to pass a number to the size property. This would work but there are two downsides:

  • it is harder to keep the size of different spinners consistent across pages and projects
  • the size is mapped to three properties: height, width and border-width. We need extra logic to calculate the border width based on an arbitrary size in pixels or rems
@nlopin nlopin added the enhancement New feature or request label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant