Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using Ruby v1.9 hash syntax in Hash#mocha_inspect #651

Closed
floehopper opened this issue Jun 16, 2024 · 2 comments · Fixed by #719
Closed

Consider using Ruby v1.9 hash syntax in Hash#mocha_inspect #651

floehopper opened this issue Jun 16, 2024 · 2 comments · Fixed by #719
Labels

Comments

@floehopper
Copy link
Member

floehopper commented Jun 16, 2024

We're still using the hash rocket style here whereas we've already changed the code and the documentation.

Are there any reasons not to make this change? Perhaps it makes the distinction between a keyword-style hash and a normal hash less clear...?

@floehopper
Copy link
Member Author

It looks as if we fixed this for Ruby keyword arguments in #652. Perhaps we can use the same code for a non-keyword argument Hash...?

@floehopper
Copy link
Member Author

In #588 I had some concerns about the only distinction between a standard Hash and a keyword argument Hash being the wrapping braces. However, I'm now convinced that this is OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant