Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Change behavior of communityflag #1051

Open
FFHener opened this issue Nov 4, 2024 · 5 comments
Open

RFC: Change behavior of communityflag #1051

FFHener opened this issue Nov 4, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@FFHener
Copy link
Contributor

FFHener commented Nov 4, 2024

I would like to change the behavior of the communityflag. Currently it only sets the default values for contact details. I think it could make sense to change it to community:berlin and control other parameters like the default SSID as well. In this way other communities like hacrafu und Fürstenwalde could use this flag to set their defaults within bbb-configs.

@Noki
Copy link
Member

Noki commented Nov 4, 2024

Sounds like a good idea. Maybe leave the variable name as is and just change the logic to handle different values or did you mean this with community:berlin?

value descripton
false same as abesent (private location that requires specific contact data to be set)
true same as berlin (defautl so we do not need to change all locations)
berlin Freifunk Community Berlin
hacrafu Freifunk Community Hacrafu
fffw Freifunk Community Fürstenwalde

Based on that we can set contact information, install SSH-Keys and so on.

We could even extend this to handle defaults for organizations that have multiple locations e.g. K12, Weidenbaum, HDK, Stadtfunk, ... if we want.

@FFHener FFHener added the enhancement New feature or request label Nov 4, 2024
@FFHener
Copy link
Contributor Author

FFHener commented Nov 4, 2024

I would leave out true so we dont get a lot of legacystuff since it easy to change this treewide. Why do you think it makes sense to keep it?

@Noki
Copy link
Member

Noki commented Nov 4, 2024

cause I am lazy...

@FFHener
Copy link
Contributor Author

FFHener commented Nov 4, 2024

Search and Replace will do it easily :D

@spolack
Copy link
Member

spolack commented Nov 15, 2024

Sounds like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants