-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: add ip prefix duplicate check / fix duplicates #905
Conversation
d1bbfbc
to
b181ace
Compare
Thank you for writing this check. It feels kind of hacky to use a bash-script with a regex. Could there be a cleaner way using ansible tasks instead as it interprets everything as variables and not just as a random text file? |
dcc3680
to
2cea743
Compare
Using ansible would be cleaner, but that's nothing I can do right now. Feel free to add an issue to rewrite this later on when someone has time. For now any check is better than no check. This is ready for review and to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, but I am not an shell expert. We might want an additional review
10edd30
to
9e96865
Compare
9e96865
to
c008e4f
Compare
This is the kind of linter I like :) can be run locally and solves a real problem 👍
|
This ensures that we do not have duplicate IP prefixes any more:
closes #901