Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: add ip prefix duplicate check / fix duplicates #905

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

Noki
Copy link
Member

@Noki Noki commented Jul 22, 2024

This ensures that we do not have duplicate IP prefixes any more:

image

closes #901

@Noki Noki force-pushed the ip-prefix-duplicate-check branch from d1bbfbc to b181ace Compare July 22, 2024 11:35
@FFHener
Copy link
Contributor

FFHener commented Jul 22, 2024

Thank you for writing this check. It feels kind of hacky to use a bash-script with a regex. Could there be a cleaner way using ansible tasks instead as it interprets everything as variables and not just as a random text file?

@Noki Noki force-pushed the ip-prefix-duplicate-check branch 4 times, most recently from dcc3680 to 2cea743 Compare July 22, 2024 12:08
@Noki
Copy link
Member Author

Noki commented Jul 22, 2024

Thank you for writing this check. It feels kind of hacky to use a bash-script with a regex. Could there be a cleaner way using ansible tasks instead as it interprets everything as variables and not just as a random text file?

Using ansible would be cleaner, but that's nothing I can do right now. Feel free to add an issue to rewrite this later on when someone has time. For now any check is better than no check.

This is ready for review and to be merged.

@Noki Noki mentioned this pull request Jul 22, 2024
6 tasks
Copy link
Contributor

@FFHener FFHener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but I am not an shell expert. We might want an additional review

@FFHener FFHener requested a review from pktpls July 22, 2024 12:28
@Noki Noki changed the title workflows: add ip prefix duplicate check workflows: add ip prefix duplicate check / fix duplicates Jul 22, 2024
@Noki Noki force-pushed the ip-prefix-duplicate-check branch 2 times, most recently from 10edd30 to 9e96865 Compare July 22, 2024 16:30
@pktpls pktpls force-pushed the ip-prefix-duplicate-check branch from 9e96865 to c008e4f Compare July 24, 2024 23:00
@pktpls
Copy link
Contributor

pktpls commented Jul 24, 2024

This is the kind of linter I like :) can be run locally and solves a real problem 👍

Also add them to make lint when all are merged. - oh wait, make lint doesn't exist here yet

@pktpls pktpls merged commit 48e3721 into main Jul 24, 2024
10 checks passed
@pktpls pktpls deleted the ip-prefix-duplicate-check branch July 24, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linter: check for IPv6 duplicates
3 participants