Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing field validation #14

Open
geirkairam opened this issue Oct 17, 2015 · 4 comments
Open

add missing field validation #14

geirkairam opened this issue Oct 17, 2015 · 4 comments
Assignees
@geirkairam
Labels
angular

Comments

@geirkairam
Copy link
Member

  • ips (if automatic register is nor selected)
  • vpn key and cert (if internetsharing & von03 & not generate cert and key)
@geirkairam geirkairam self-assigned this Oct 17, 2015
@andrenarchy
Copy link
Member

For IPs I'd like to include an npm package, for example ip. This means that we have to use browserify for bundling npm modules. I can set this up later today...

@andrenarchy andrenarchy mentioned this issue Oct 17, 2015
Merged
geirkairam added a commit that referenced this issue Oct 17, 2015
@geirkairam
Issue #14: add missing field validation (ipv4 fields)
f8ff24d 
add validation for IPv4 fields. for now this is done with regex
patterns. we may change to the ip npm package later.
geirkairam added a commit that referenced this issue Oct 17, 2015
@geirkairam
Issue #14: add missing field validation
d5ffdce 
add validation for file upload fields
geirkairam added a commit that referenced this issue Oct 18, 2015
@geirkairam
Issue #14 add missing field validation (router name / email)
5ec9a2a 
if IPs should be registered automatically and the VPN files should be
generated automatically the router name and user email are required.
geirkairam added a commit that referenced this issue Oct 18, 2015
@geirkairam
Issue #14 validate subnet and v6prefix field
65a3a39
@geirkairam
Copy link
Member Author

what is the point of using the ip package if there is still a custom regex validation and the ip is validated against 255.255.255.255 > shouldn't this be checked against our berlin ipv4 ranges?
also I don't think this can handle ipv6 addresses, can it?

@booo
Copy link
Member

booo commented Oct 18, 2015

Read the source luke

The proposed package should support ipv6.

@geirkairam
Copy link
Member Author

thank you for this helpfull comment^^
indutny/node-ip#33
indutny/node-ip#20

geirkairam added a commit that referenced this issue Oct 24, 2015
@geirkairam
Issue #14: ip validation
8e9a8bd 
use regex to validate ipv6 subnet and ipv4 subnet. change
implementation for ipv4 directive to handele subnets and ipv6 addresses,
too.
geirkairam added a commit that referenced this issue Nov 10, 2015
@geirkairam
Issue #14: validate router name
897880d 
also show error message if any special characters are entered
geirkairam added a commit that referenced this issue Nov 10, 2015
@geirkairam
Issue #14: validate router name
ec884bd 
handle router name length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geirkairam geirkairam

Labels
angular
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@booo @geirkairam @andrenarchy