Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ff3l-badblocks-disable-autoupdater: init #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kpanic23
Copy link

@kpanic23 kpanic23 commented Jul 18, 2024

Transitional package to be used with last Gluon v2019.1.x release
Simply disables the autoupdater for UBNT ERX devices with bad eraseblocks in flash and prefixes the node's name with #BADBLOCKS.
This mitigates the issue that these devices would get bricked by an update to Gluon v2020.1 or newer, where the handling of bad eraseblocks has been changed.

$(CP) $(PKG_BUILD_DIR)/luadest/* $(1)/
endef

$(eval $(call BuildPackage,ff3l-badblocks-disable-autoupdater))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100% sure, but I think you can remove L16 to L29 and use BuildPackageGluon which does similar things?

Suggested change
$(eval $(call BuildPackage,ff3l-badblocks-disable-autoupdater))
$(eval $(call BuildPackageGluon,$(PKG_NAME)))

Copy link
Member

@maurerle maurerle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kpanic23 , it seems that you are not yet part of community-packages maintainers.
I think @blocktrron or someone else with permission will add you to the group as this gets merged.

This package is only required for gluon versions < v2020.1, but it is still very useful :)
Would you mind referencing to this thread in the README which explains things nicely imo:
https://github.com/oszilloskop/UBNT_ERX_Gluon_Factory-Image/blob/master/ERX-Sysupgrade-Problem.md

endef

define Build/Compile
$(call GluonSrcDiet,./luasrc,$(PKG_BUILD_DIR)/luadest/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure that this package does nothing on later releases? Can we somehow check the current version and if >2019 just don't add any files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants