ffac-autoupdater-wifi-fallback: remove requirement of wpa-supplicant #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurerle
changed the title
maurerle
changed the title
maurerle
force-pushed
the
improve_autoupdater_wifi_fallback
branch
from
fdc001a to
6577d3a
Compare
|
Tested with v2023.2.x on o2-6431. Worked fine, did connect to another Freifunk AP successfully.. |
|
@mbaumga is this PR fine for you as well? :) |
Sure. Looks fine to me. :) |
|
@maurerle am i wrong or is the indentation broken with your changes? |
maurerle
force-pushed
the
improve_autoupdater_wifi_fallback
branch
from
6577d3a to
ff62ced
Compare
rotanid
reviewed
Nov 2, 2024
ffac-autoupdater-wifi-fallback/luasrc/usr/sbin/autoupdater-wifi-fallback
Outdated
Show resolved
Hide resolved
rotanid
reviewed
Nov 2, 2024
ffac-autoupdater-wifi-fallback/luasrc/usr/sbin/autoupdater-wifi-fallback
Outdated
Show resolved
Hide resolved
rotanid
reviewed
Nov 2, 2024
ffac-autoupdater-wifi-fallback/luasrc/lib/gluon/upgrade/510-autoupdater-wifi-fallback
Show resolved
Hide resolved
rotanid
approved these changes
Nov 2, 2024
… old wireless config change, remove unrequired ubus calls and params
maurerle
force-pushed
the
improve_autoupdater_wifi_fallback
branch
from
ff62ced to
8dca97b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally fixes the additional wpa-supplicant-mini requirement for the ffac-autoupdater-wifi-fallback (see issue #33 (comment) for more information).
As the functionality is quite handy to have it on all devices, it should not be bloated.
The package does now works again with gluon releases v2022.x and v2023.x (and should still work on older releases) without additional wpasupplicant packages.
It uses
ubus call add_dynamicto add a network at runtime and then attach it to a network device.