ffac-mesh-vpn-wireguard-owrt19: fix all shellcheck issues #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grische
force-pushed
the
fix/shellcheck-ffac-mesh-vpn-wireguard-openwrt19
branch
from
eba7d57 to
4fa0140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShellCheck has no "first class support" for
busbox sh, but instead relies on theashparsing that in turn uses Debian'sdashimplementation.So I do (correctly) specify
#!/bin/busybox shbut then tell shellcheck to also accept dash parsing.See https://www.shellcheck.net/wiki/SC2187 for more details.