Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wecanhelp as a new provider to the enum. #163 #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added wecanhelp as a new provider to the enum. #163 #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions specs/development.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,10 @@
"type": "string",
"title": "Campaign Providers",
"description": "Where do you host your donations?",
"enum": [ "", "betterplace", "boost" ],
"default": ""
"enum": ["", "betterplace", "wecanhelp"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please leave boost in there, some communities and tools will have these values still set.

So we have a chance to migrate and remove boost later

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please leave boost in there, some communities and tools will have these values still set.

So we have a chance to migrate and remove boost later

I have made the requested changes, please review and let me know if this fixes it!

Copy link
Author

@YashSarnobat YashSarnobat Mar 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please leave boost in there, some communities and tools will have these values still set.
So we have a chance to migrate and remove boost later

I have made the requested changes , please review and let me know if this fixes it!
PR: #174

"default": "",
"deprecated": true,
"deprecatedDescription": "This provider is deprecated and will be removed in a future version."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with that you would deprecate the whole field, not just a single entry

},
"projectid": {
"type": "string",
Expand Down