Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages should have "PKGARCH=all" set #29

Open
SvenRoederer opened this issue Jun 19, 2020 · 3 comments
Open

packages should have "PKGARCH=all" set #29

SvenRoederer opened this issue Jun 19, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@SvenRoederer
Copy link
Contributor

SvenRoederer commented Jun 19, 2020

currently there is no binary in any of the packages, so they can safely be set to PKGARCH=all.
For this we rely on the luci.mk if the luci-feed which defines LUCI_PKGARCH?=$(if $(realpath src/Makefile),,all) (https://github.com/openwrt/luci/blob/c351beea561acafa088a3fd3d82bfec93ee45cd4/luci.mk#L12) for some reason this seems no to be evaluated correctly. So we end up in having ARCH-specifiy packages without any need.

@aparcar
Copy link
Contributor

aparcar commented Mar 14, 2021

Ping?

@SvenRoederer
Copy link
Contributor Author

Had not a chance to look for the current situation for some time ....

@SvenRoederer
Copy link
Contributor Author

On my build I'm including PR openwrt/luci#2637 which this background link to luci.mk (via freifunk.mk) packages become ARCH=all. tested with OpenWrt-21.02.

For packages not using frefunk.mk wrapper manual adjustments are still needed. I'll see what @jow- will decide on the mentioned PR and then change our packages to either way.

SvenRoederer added a commit that referenced this issue Jun 19, 2021
…i.mk) helper

Update the single package definiton in teh contrib folder to use the improved capabilities
to customize a package build via the luci.mk helper. Using this helper gives a lot of
automagic and reduces maintenance (AutoVersioning, LUA_SRCDIET, package-naming, ...).

relevant changes in LuCI-repo:
* openwrt/luci@de2c045
* openwrt/luci@ae0795d
* openwrt/luci@209141d
* openwrt/luci@2b11ec6
(master and openwrt-21.02 branches only)

This change also fixes issue #29 by auto-detecing target "ALL" for most packages.

Signed-off-by: Sven Roederer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants