-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_resource()
includes schema verbosely when only url to schema is required
#270
Comments
write_package()
writes inline schema when only url to schema is required
write_package()
writes inline schema when only url to schema is requiredadd_resource()
includes schema verbosely when only url to schema is required
@sannegovaert wanna take a stab at this? I think it can be done by adding: schema_url <- if (is_url(schema)) schema else NULL To: frictionless-r/R/add_resource.R Lines 150 to 152 in 8614cf5
And then using frictionless-r/R/add_resource.R Line 192 in 8614cf5
frictionless-r/R/add_resource.R Line 204 in 8614cf5
And testing for it. |
Can be removed when frictionlessdata/frictionless-r#270 is implemented.
I addition, I think
|
add_resource()
is used for the development ofwrite_camtrapdp()
.The resources are added with
add_resource(schema = path)
, whereas for schema a path is provided, e.g. "https://raw.githubusercontent.com/tdwg/camtrap-dp/1.0.1/observations-table-schema.json".add_resource()
adds the schema verbosely, while we just want to keep the url.The text was updated successfully, but these errors were encountered: