Skip to content
This repository has been archived by the owner on Sep 12, 2022. It is now read-only.

Search box in specs.frictionlessdata.io not working (as I expected) #187

Closed
cpina opened this issue May 30, 2020 · 4 comments
Closed

Search box in specs.frictionlessdata.io not working (as I expected) #187

cpina opened this issue May 30, 2020 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@cpina
Copy link

cpina commented May 30, 2020

Steps to reproduce:
-Open https://specs.frictionlessdata.io/#overview
-In the search box type "zip" and press enter

Expected:
-List of pages with the term "zip" or a "no pages contain the term zip"

Actual:
-Nothing happens :-(

After doing this I realised that if I type "a" (or a single letter) it shows the list of headers. Or if I type "adding" it shows the headers having "adding" in the title. But this is not what I expected initially obviously.

@cpina
Copy link
Author

cpina commented May 30, 2020

BTW, if a requirement for simplicity is a client side full text search I'm sure that there are different solutions (I'm not familiar with them). The only example that comes to my mind: in https://nlnet.nl/ they use "Zero-leak Search" for searching, client side. E.g. https://nlnet.nl/search/static.html?q=zip&submit=Search#zeroleak , they use: http://searsia.org/

@risenW risenW transferred this issue from frictionlessdata/forum Nov 10, 2020
@mccalluc
Copy link

mccalluc commented Feb 2, 2021

Similar story. Looking for the documentation of validate_table on https://frictionlessdata.io/: I paste that string into the search box, and there is no response.

  • Ideally, it would locate the docs for the function.
  • Short of that, it should indicate that there are no matches for the search.

@roll roll transferred this issue from frictionlessdata/frictionlessdata.io May 24, 2021
@roll roll added the enhancement General improvements label May 25, 2021
@roll roll moved this to Done in Open Knowledge Dec 26, 2021
@roll roll removed the status in Open Knowledge Dec 26, 2021
@roll roll added bug Something isn't working and removed enhancement General improvements labels Mar 29, 2022
@roll roll self-assigned this Apr 11, 2022
@roll roll moved this to Blocked in Open Knowledge Apr 11, 2022
@roll roll moved this from Blocked to Priority in Open Knowledge Apr 11, 2022
@roll roll assigned aivuk and unassigned roll Apr 11, 2022
@aivuk aivuk moved this from Priority to Current in Open Knowledge Apr 25, 2022
@aivuk
Copy link
Contributor

aivuk commented Apr 25, 2022

@cpina Thanks! The first example "zip" currently show results, probably fixed since you wrote the issue (almost two years!). But I agree that it would be better to display a message like "not found" when there are no results. I also agree that a minimum number of characters to be typed before searching is a nice feature.

@mccalluc Currently the Frictionless framework documentation is at https://framework.frictionlessdata.io/ where the search has improved a lot since your reported this issue.

@roll roll added question Further information is requested and removed bug Something isn't working labels Apr 25, 2022
@roll
Copy link
Member

roll commented Apr 25, 2022

Thanks @aivuk!

I've created an issue for it - frictionlessdata/frictionlessdata.io#880

Closing this one as resolved

@roll roll closed this as completed Apr 25, 2022
Repository owner moved this from Current to Done in Open Knowledge Apr 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
Archived in project
Development

No branches or pull requests

4 participants