Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerizing PyNode apps #32

Open
ozanerturk opened this issue Aug 29, 2021 · 3 comments
Open

Dockerizing PyNode apps #32

ozanerturk opened this issue Aug 29, 2021 · 3 comments

Comments

@ozanerturk
Copy link

Thanks a lot for this library, it is amazingly fast! Just awesome.

It is hard to find a docker image able to run pynode apps so i made one,
https://github.com/ozanerturk/pynode-docker-example
Firstly I wanted to add into this repo by PR but not sure where to put it.
If you like the idea we could discuss how to add it into this repository.

Bests,

@fridgerator
Copy link
Owner

Glad to hear that you like the library.

Yes I like the idea of adding Docker to the repository, I use Docker whenever I can. Perhaps an 'examples' or 'docker' folder with a simple example? Or did you have another idea?

@ozanerturk
Copy link
Author

Great. Both actually.
Docker folder will contain a dockerfile and endpoint.sh script etc which builds image for pynode. Let's start with a particular node.js and python version later we could add a version matrix and proper workflows to update docker releases
'example' folder would includes an example docker app which based on "pynode" docker image.

If these are ok I can start with these and create a pull requests then we can proceed on there. A
_-------
And friend, this lib deserves more reputation that it is. It is just amazing and fast!! Traditional ways are hard to manage(child processes) and have some speed drawbacks. Thank you for that again.

@fridgerator
Copy link
Owner

Yes that implementation sounds good to me 👍

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants