Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policies #9

Open
ledoyen opened this issue Jul 12, 2018 · 3 comments
Open

Policies #9

ledoyen opened this issue Jul 12, 2018 · 3 comments
Labels
community feedback wanted Feedback is needed to decide if a feature must be implemented enhancement New feature or request

Comments

@ledoyen
Copy link
Contributor

ledoyen commented Jul 12, 2018

Implement CRUD operations on policies, as defined here https://www.rabbitmq.com/parameters.html#policies

CRUD methods of Policies must be available on MockConnectionFactory as it makes no sense to have the opened/closed semantic of a Connection or even a Channel when it comes to Policy definition.

Policies will affect only the following extensions (the other being not implemented):

  • alternate exchanges
  • dead lettering
  • per-queue TTLs
  • maximum queue length
@ledoyen ledoyen added the enhancement New feature or request label Jul 12, 2018
@ledoyen ledoyen added the community feedback wanted Feedback is needed to decide if a feature must be implemented label Feb 11, 2019
@RedMu
Copy link
Contributor

RedMu commented Jul 1, 2020

I've started working on this - I'll get a PR ready with alternative exchange, dead letter exchange and dead letter routing keys together first.

@ledoyen
Copy link
Contributor Author

ledoyen commented Jul 3, 2020

Hi again @RedMu, thanks for your work !

I created it while ago, but at that time no one really needed it so I let it go stale.

I wonder, is this a feature you need in projects ?

@RedMu
Copy link
Contributor

RedMu commented Jul 3, 2020

No problem, I've found the library very useful so I'm happy to contribute.

I would like to implement the x-modulus-hash exchange but it only really makes sense with policies in place so when I saw this issue I thought I'd get it done. I've got a few more tests to finish up for alternative exchange, dead letter exchange and dead letter routing key and I'll push it back for you to see.

I'll need to make some changes to the way way expiry is calculated for the ttl policies, so I'll get the other stuff back first.

RedMu added a commit to RedMu/rabbitmq-mock that referenced this issue Jul 6, 2020
RedMu added a commit to RedMu/rabbitmq-mock that referenced this issue Jul 6, 2020
RedMu added a commit to RedMu/rabbitmq-mock that referenced this issue Jul 7, 2020
RedMu added a commit to RedMu/rabbitmq-mock that referenced this issue Jul 7, 2020
RedMu added a commit to RedMu/rabbitmq-mock that referenced this issue Jul 7, 2020
RedMu added a commit to RedMu/rabbitmq-mock that referenced this issue Jul 7, 2020
RedMu added a commit to RedMu/rabbitmq-mock that referenced this issue Jul 7, 2020
RedMu added a commit to RedMu/rabbitmq-mock that referenced this issue Jul 7, 2020
RedMu added a commit to RedMu/rabbitmq-mock that referenced this issue Jul 7, 2020
RedMu added a commit to RedMu/rabbitmq-mock that referenced this issue Jul 7, 2020
RedMu added a commit to RedMu/rabbitmq-mock that referenced this issue Jul 7, 2020
RedMu added a commit to RedMu/rabbitmq-mock that referenced this issue Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community feedback wanted Feedback is needed to decide if a feature must be implemented enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants