-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VCF header fields missing #189
Comments
I am suffering the exact same problem here as you were. But I did not set SNP cuz I am not intended to study SNP, only SVs are of my interest.
To fix it? |
OK I figured it out, besides that line of code, we also need to add headers like this manually:
|
Hi @rl4940, (disclaimer: I am not a maintainer of SURVIVOR, I just tried to fix a bug here) |
Hello Fritz & SURVIVOR dev team,
What.
I attempted to use the VCF file generated by SURVIVOR with bcftools, as for instance recommended in issue #173. However, bcftools suffers from a bug that originates from SURVIVOR I think.
Error.
When using bcftools (sort+index) on SURVIVOR's truthset VCF, I get warnings and an error regarding the VCF header not matching the FORMAT fields.
I looked into the code at
SURVIVOR/src/simulator/SV_Simulator.cpp
Line 951 in ed1ca51
print_vcf_header2
function above is the corresponding header than the FORMAT fields indeed do not match.Solution.
I propose two trivial solutions here:
I am voting for solution 1 here because:
a) I think FT, RC, DR, DV, RR, RV are ancient relics of Lumpy unrelated to SNPs. Also these FORMAT fields have been commented out throughout most of SURVIVOR.
b) The missing fields are not part of the VCF4.2 standard and should not be present if not defined and used.
c) I tested that the VCF file generated by SURVIVOR works flawlessly with bcftools if the fields are removed from SNP records. (see hotfix below)
Hotfix.
sed -i 's/GT:GL:GQ:FT:RC:DR:DV:RR:RV/GT/g ' simulated.vcf
where simulated.vcf is the VCF by SURVIVOR.The text was updated successfully, but these errors were encountered: