Support Froala Editor (wysiwyg-rails) 3.x too #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would also like to see this merged in. I'm currently upgrading a Rails app from 5.2 to 6.0 but I'm unable to upgrade and use the Froala editor.
|
|
This has become obsolete with the release of Froala / wyswyig-rails 4.x, but I would still be in favour of loosening the locks. This just doesn't seem sensible to me:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only loosening the lock works for everything we are using (which is FroalaEditorSDK::S3). Not sure if the rest of this gem also works with Froala 3, maybe somebody could verify that before merge.
If I need to update the (Tiny) version in version.rb please let me know.