Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imports to use namespaces to be compatible with [email protected] #43

Closed
wants to merge 1 commit into from

Conversation

peterjuras
Copy link

Fixes #42

@frostney
Copy link
Owner

frostney commented Jan 9, 2017

Thank you. This is amazing! 👍
Let me just quickly test this for myself, because I don't believe I have any RN 0.40 projects yet.

@peterjuras
Copy link
Author

Did you find time to test the PR yet?

Copy link

@jeffreyroshan jeffreyroshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge this.

@frostney
Copy link
Owner

frostney commented Feb 1, 2017

I would prefer not to break backwards compatibility if we could avoid it. Would it be possible to update this PR to cater for this @peterjuras ?
I found a sensible approach to this here: https://medium.com/@thisismissem/how-to-upgrade-react-native-modules-in-a-backwards-compatible-manner-a5b5c48d590c#.ku4y0zjq3
What's your opinion on this?

@peterjuras
Copy link
Author

Personally, I don't think it is worth it to hold up backwards compatibility, since react-native is still not out of beta and changing quickly.

Also, it appears that almost no react-native library has chosen to go with this path (I only saw Microsoft's code-push do these sorts of imports), therefore a lot of projects have to migrate anyways because big libraries (e.g. react-native-vector-icons, facebook's own react-native-fbsdk) did not migrate in a backwards compatible way.

However, this is your repo, therefore I leave the choice up to you. I created an alternative pull request that imports the header with the way you described and it works for both 0.40 and 0.39. I don't recommend it though.

Feel free to choose any of the approaches.

@peterjuras
Copy link
Author

Any update on the merging of a PR alternative?

@plbrault
Copy link

plbrault commented Mar 6, 2017

@frostney Any update?

@cahalane
Copy link

Please merge one of the options available! The iOS side of my app is being stalled by this.

@PeterKow
Copy link

Yes can we merge this? We are using it in our app with NR 42.3 and with those changes everything works nicely :) 👍

@leesolway
Copy link

Any news on this being merged?

@peterjuras
Copy link
Author

I've since moved to react-native-beacons-manager. It has a similar (or pretty much the same API) and works under iOS and Android with newer react-native versions.

I feel bad for "advertising" an alternative, but this might at least be something worthwhile to check out while this is being updated ...

@peterjuras
Copy link
Author

Closed due to inactivity of repository.

@peterjuras peterjuras closed this Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Breaking] Header files moved with [email protected]
8 participants