Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new "ignorerevs_files" setting #65

Open
frou opened this issue May 29, 2021 · 2 comments
Open

Add a new "ignorerevs_files" setting #65

frou opened this issue May 29, 2021 · 2 comments

Comments

@frou
Copy link
Owner

frou commented May 29, 2021

There could be a new setting in this package called either "auto_discover_ignorerevs_file" (default false), or "ignorerevs_file" (default ""). The latter would be more flexible since it's not guaranteed that such a file always uses the conventional .git-blame-ignore-revs name (example). In either case the new setting should default to disabled, because by default I don't think this package should show different results than running plain git blame on the commandline does.

The file should be checked for relative to the root of the repo (discovered by calling git rev-parse --show-toplevel) and if it exists then --ignore-revs-file /path/to/file arguments should be added to calls to git.

We make use of the related --ignore-rev SHA option already as a way to build up state when pressing the [Prev] button to step back through commits in the UI.

Originally posted by @frou in #58 (comment)


Addendum: It should be "ignorerevs_files" (plural) and have an array as a value, so that multiple possibilities can be listed in descending priority.

@frou
Copy link
Owner Author

frou commented Jan 29, 2022

@frou
Copy link
Owner Author

frou commented Apr 14, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant