Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTRL - Banca Transilvania Romania #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

avramflorin
Copy link

add new Engine for BT Banca Transilvania

1100 => Engine\Kbs::class,
1200 => Engine\Zetb::class,
1300 => Engine\Kontist::class,
1100 => Engine\Btrl::class,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kbs, Zetb and Kontist should not be deleted.

@@ -78,22 +78,4 @@ public function testIssue48()
$this->assertEquals('15-12-2016', $transactions[1]->getValueTimestamp('d-m-Y'));
$this->assertEquals('15-12-2016', $transactions[1]->getEntryTimestamp('d-m-Y'));
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test methods should not be deleted.

@@ -48,22 +48,4 @@ public function testParseTransactionEntryTimestamp()
$lastTransaction = end($transactions);
$this->assertEquals('02-01-2020', $lastTransaction->getEntryTimestamp('d-m-Y'));
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test methods should not be deleted.

@@ -51,22 +51,4 @@ public function testParseTransactionEntryTimestamp()
$lastTransaction = end($transactions);
$this->assertEquals('24-05-2019', $lastTransaction->getEntryTimestamp('d-m-Y'));
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test methods should not be deleted.

@@ -54,22 +54,4 @@ public function testParseTransactionEntryTimestamp()
$lastTransaction = end($transactions);
$this->assertEquals('2010-07-21', $lastTransaction->getEntryTimestamp('Y-m-d'));
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test methods should not be deleted.

@@ -89,22 +89,4 @@ public function testEndPrice() {
$price_f = $statements[0]->getEndPrice();
$this->assertSame(13057.49 , $price_f);
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test methods should not be deleted.

@@ -52,22 +52,4 @@ public function testParseTransactionEntryTimestamp()
$lastTransaction = end($transactions);
$this->assertEquals('30-09-2020', $lastTransaction->getEntryTimestamp('d-m-Y'));
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test methods should not be deleted.

@@ -108,22 +108,4 @@ public function testHandlingOfPREF() {
$statements = $this->engine->parse();
$this->assertSame('PmtInfId-20151208-987', $statements[0]->getTransactions()[1]->getDescription());
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test methods should not be deleted.

@@ -51,13 +51,4 @@ public function testParsesAllFoundStatements()
$this->assertEquals('18-02-2010', $last->getStartTimestamp('d-m-Y'));
$this->assertEquals('18-02-2010', $last->getEndTimestamp('d-m-Y'));
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test methods should not be deleted.

@fruitl00p
Copy link
Owner

Seems that this might need a rebase on the latest master (to prevent deletion of the other engines / test files?)

@avramflorin might that resolve the various issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants