Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call set_gating_sequences() in file one_publisher_to_one_unicast_throughput_test.cc #33

Open
paulran opened this issue Sep 18, 2016 · 2 comments
Open

Call set_gating_sequences() in file one_publisher_to_one_unicast_throughput_test.cc #33

paulran opened this issue Sep 18, 2016 · 2 comments

Comments

@paulran
Copy link

paulran commented Sep 18, 2016

master/perf/one_publisher_to_one_unicast_throughput_test.cc#L70

Why do not call ring_buffer.set_gating_sequences() before this line, although the file just is for performance testing?

This is unfavorable for beginners, and is not precise.
@tvdijk
Copy link

tvdijk commented Feb 2, 2017

I agree. Also, in one_publisher_to_three_pipeline_throughput_test, the publisher there will also not wait for any consumer, it should wait for third_processor.

@fsaintjacques
Copy link
Owner

Please open a PR, I don't have much personal time to work on this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fsaintjacques @tvdijk @paulran