-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variety in Line Shapes #85
Comments
Hey @cjperks7 , this all sounds great! Strong encouragement from my side. Only concern: please try not to make your code specific to one application or another, but keep it general for other users. I know of several people across institutions who may be interested in these developments and could contribute at some point! Worth mentioning: one challenge is to make the code efficient. If you do something super detailed, but it takes minutes to run, it may be good, but would have different applications. What is currently in Aurora isn't optimized for many calculations and line-integrals, but gives the gist of it (the more optimized version was used for BITS for C-Mod analysis, you might remember). |
@fsciortino, I understand the concerns you point out under all my posts. I will be clear with providing minimum working examples so that you can quickly see progress yourself and provide feedback on flexibility. This will probably be an ongoing enhancement for a while before PR as I work on other physics in parallel (as always...) so hopefully you can review at your leisure. FYI I have thought about using BITS to see what its basis functions would say about suprathermal ion features. Down the line though |
As I work on this, feel free to point whatever collaborators you're thinking of my way if you ever get the chance. More people with eyes on this can assure flexibility. |
@fsciortino Can I get write access to the Aurora repo? |
@cjperks7 done! |
Thank you very much! |
…ions that can be shared amongst similar broadening mechanisms
…efficient is related to: either central wavelength or adf15 isel
…aussians each with a known variance. NOTE: Assumes no systematic shift as isgit add aurora/line_broaden.py git add aurora/line_broaden.py
…hod so included an alternative using scipy's built-in function
Due to my various needs, I would like there to be more flexibility available in
aurora.radiation.get_local_spectrum()
. I nominate myself to address these needs on appropriate branches to be reviewed by @fsciortino .NOTE: In my efforts, I will be heavily relying on functions and data files from the Flexible Atomic Code (FAC, https://github.com/flexible-atomic-code/fac). This is because it can satisfy missing components to my needs not covered under OpenADAS. FAC may therefore become a hidden dependency when utilizing specific upgrades I need. Care would be taken for a more general user to have options to avoid this when possible.
Issue
Currently, only Doppler broadening is available for the line shape. I would like to convolute other shape due to other physics.
Motivation
Plan of Action
aurora.radiation.get_local_spectrum
that calculates the Doppler broadening profile will be moved to a hidden sub-function@fsciortino any opinions?
The text was updated successfully, but these errors were encountered: