Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R outputs to standard out, which breaks FsAutoComplete #160

Open
rneatherway opened this issue Nov 13, 2015 · 8 comments · Fixed by #162
Open

R outputs to standard out, which breaks FsAutoComplete #160

rneatherway opened this issue Nov 13, 2015 · 8 comments · Fixed by #162
Labels
Type: Bug Something is broken!

Comments

@rneatherway
Copy link

Ref: fsharp/emacs-fsharp-mode#33

The R output on standard out is interleaved with the JSON messages being sent to the editors. I'd like to explore whether we can prevent these spurious messages from being printed here.

@rneatherway
Copy link
Author

Example of output:

[[425]]
[[425]]$name
[1] "findPackageEnv"

[[425]]$type
[1] "closure"

[[425]]$params
[[425]]$params[[1]]
[1] "info"

@tpetricek
Copy link
Member

This is mysterious - we must just be accidentally printing this somewhere - e.g. a leftover of some debugging attempts!

As documented here, the R provider starts a separate process (see here) that actually runs R and so I don't see how output from R could accidentally get into the output of the console that is calling the main type provider library.

tpetricek added a commit to tpetricek/FSharp.RProvider that referenced this issue Nov 14, 2015
@tpetricek tpetricek reopened this Nov 14, 2015
@jmp75
Copy link
Contributor

jmp75 commented Nov 14, 2015

Let me know if I can do something with the AutoPrint behavior. It's been unfortunately an occasional practical stumbling block for users on different fronts whether it defaults to true or false.

@ghost
Copy link

ghost commented Nov 16, 2015

@tpetricek The issue is solved.
R sometimes could still break autocomplete by sendng warning messages but it's easy to suppress those warning from R.
Thanks for helps.

@tpetricek
Copy link
Member

@jmp75 I think the AutoPrint behavior is fine as it is - the fact that we can enable/disable it when creating the engine is really all we need in R provider :-).

@ghost
Copy link

ghost commented Dec 10, 2015

It happens again. I have no idea where the output comes from so I can't suppress it:
Error: F# completion process produced malformed JSON (Loading required package: spd).
Loading any packages causes this. I tried several R packages: Rcpp, spatial, spd.

@tpetricek tpetricek reopened this Dec 10, 2015
@tpetricek
Copy link
Member

Reopening. Is there a good way of getting a log of what gets sent to the FsAutoComplete so that I can more easily reproduce this?

@rneatherway
Copy link
Author

@tpetricek the easiest way I found to reproduce it was with FsAutoComplete standalone, see this comment: fsharp/emacs-fsharp-mode#33 (comment)

I am really interested to know if there is some way FsAutoComplete can just suppress subprocesses from outputting, as otherwise this could keep happening.

@dsyme dsyme added the Type: Bug Something is broken! label Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something is broken!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants