Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible to trace usage of overload #557

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Possible to trace usage of overload #557

merged 5 commits into from
Oct 2, 2023

Conversation

wallymathieu
Copy link
Member

  • Test traversal overload during tests

@wallymathieu wallymathieu requested a review from gusty September 30, 2023 11:21
@wallymathieu wallymathieu changed the title Trace usage Possible to trace usage of overload Sep 30, 2023
gusty
gusty approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@gusty gusty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice. We should have done it long time ago.
There is a huge diff in the .sln file, is that really needed?

@wallymathieu wallymathieu marked this pull request as ready for review October 2, 2023 10:27
@wallymathieu
Copy link
Member Author

This looks really nice. We should have done it long time ago. There is a huge diff in the .sln file, is that really needed?

The main reason for the huge diff is due to the fact that Visual Studio configures the solution to specify that the build should use Test-configuration in some cases.

@wallymathieu
Copy link
Member Author

Perhaps it could be that Visual Studio is confused around the identity of the FSharpPlus fsproj and has recreated the configurations.

@gusty gusty merged commit c1ebe74 into master Oct 2, 2023
6 checks passed
@gusty gusty mentioned this pull request Nov 26, 2023
Closed
@gusty gusty mentioned this pull request Jan 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusty gusty gusty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wallymathieu @gusty