Update style for function call with parenthesis around function name. (#2544)

Author: nojaf

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## Unreleased
+
+### Changed
+* Function call with parenthesis around function name. [#2382](https://github.com/fsprojects/fantomas/issues/2382)
+
 ## [5.1.0-alpha-002] - 2022-09-29
 
 ### Changed

src/Fantomas.Core.Tests/AppTests.fs

@@ -479,11 +479,10 @@ let ``parenthesis around composed function expression, 1341`` () =
     |> should
         equal
         """
-(f >> g)
-    (
-        bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb,
-        c
-    )
+(f >> g) (
+    bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb,
+    c
+)
 """
 
 [<Test>]
@@ -528,11 +527,10 @@ let ``parenthesis around simple function expression`` () =
     |> should
         equal
         """
-(ignore)
-    (
-        "Tuuuuuuuuuuuuurn Tuuuuuuuuuuuuurn Tuuuuuuuuuuuuurn Tuuuuuuuuuuuuurn tooooooooooooooooooooooo stooooooooooooooooooooooooone",
-        42
-    )
+(ignore) (
+    "Tuuuuuuuuuuuuurn Tuuuuuuuuuuuuurn Tuuuuuuuuuuuuurn Tuuuuuuuuuuuuurn tooooooooooooooooooooooo stooooooooooooooooooooooooone",
+    42
+)
 """
 
 [<Test>]
@@ -547,8 +545,9 @@ let ``parenthesis around simple function expression with single parenthesis argu
     |> should
         equal
         """
-(ignore)
-    ("Tuuuuuuuuuuuuurn tooooooooooooooooooooooo stooooooooooooooooooooooooone")
+(ignore) (
+    "Tuuuuuuuuuuuuurn tooooooooooooooooooooooo stooooooooooooooooooooooooone"
+)
 """
 
 [<Test>]
@@ -565,12 +564,11 @@ stooooooooooooooooooooooooone\"\"\")
     |> should
         equal
         "
-(ignore)
-    (
-        \"\"\"Tuuuuuuuuuuuuurn
+(ignore) (
+    \"\"\"Tuuuuuuuuuuuuurn
 tooooooooooooooooooooooo
 stooooooooooooooooooooooooone\"\"\"
-    )
+)
 "
 
 [<Test>]
@@ -1064,3 +1062,25 @@ printf "%-40s %s" "" (*<--flags*) word
         """
 printf "%-40s %s" "" (*<--flags*) word
 """
+
+[<Test>]
+let ``function invocation wrapped in parentheses, 2382`` () =
+    formatSourceString
+        false
+        """
+(ignore)
+    (
+        "Tuuuuuuuuuuuuurn Tuuuuuuuuuuuuurn Tuuuuuuuuuuuuurn Tuuuuuuuuuuuuurn tooooooooooooooooooooooo stooooooooooooooooooooooooone",
+        42
+    )
+"""
+        config
+    |> prepend newline
+    |> should
+        equal
+        """
+(ignore) (
+    "Tuuuuuuuuuuuuurn Tuuuuuuuuuuuuurn Tuuuuuuuuuuuuurn Tuuuuuuuuuuuuurn tooooooooooooooooooooooo stooooooooooooooooooooooooone",
+    42
+)
+"""

src/Fantomas.Core/CodePrinter.fs

@@ -1575,16 +1575,6 @@ and genExpr astContext synExpr ctx =
 
             fun ctx -> isShortExpression ctx.Config.MaxDotGetExpressionWidth short long ctx
 
-        // (*) (60. * 1.1515 * 1.609344)
-        // function is wrapped in parenthesis
-        | AppParenArg (Choice1Of2 (Paren _, _, _, _, _, _) as app)
-        | AppParenArg (Choice2Of2 (Paren _, _, _, _, _) as app) ->
-            let short = genAppWithParenthesis app astContext
-
-            let long = genAlternativeAppWithParenthesis app astContext
-
-            expressionFitsOnRestOfLine short long
-
         // path.Replace("../../../", "....")
         | AppSingleParenArg (LongIdentExpr lids as functionOrMethod, px) ->
             let addSpace =
@@ -3109,16 +3099,6 @@ and genMatchBangWith astContext (matchKeyword: range) (matchExpr: SynExpr) (with
         withKeyword
         "with"
 
-and genAlternativeAppWithParenthesis app astContext =
-    match app with
-    | Choice1Of2 t -> genAlternativeAppWithTupledArgument t astContext
-    | Choice2Of2 s -> genAlternativeAppWithSingleParenthesisArgument s astContext
-
-and genAppWithParenthesis app astContext =
-    match app with
-    | Choice1Of2 t -> genAppWithTupledArgument t astContext
-    | Choice2Of2 s -> genAppWithSingleParenthesisArgument s astContext
-
 and collectMultilineItemForSynExpr (astContext: ASTContext) (e: SynExpr) : ColMultilineItem list =
     match e with
     | LetOrUses (bs, e) -> collectMultilineItemForLetOrUses astContext bs (collectMultilineItemForSynExpr astContext e)
@@ -4078,11 +4058,7 @@ and genClause
         +> leadingExpressionIsMultiline
             (optPre (!- " when") sepNone eo (fun e ->
                 let short = sepSpace +> genExpr astContext e
-
-                let long =
-                    match e with
-                    | AppParenArg app -> indentSepNlnUnindent (genAlternativeAppWithParenthesis app astContext)
-                    | e -> indentSepNlnUnindent (genExpr astContext e)
+                let long = indentSepNlnUnindent (genExpr astContext e)
 
                 expressionFitsOnRestOfLine short long))
             (fun isMultiline ctx ->

src/Fantomas.Core/SourceParser.fs

@@ -1725,22 +1725,6 @@ let isSynExprLambdaOrIfThenElse =
     | SynExpr.IfThenElse _ -> true
     | _ -> false
 
-let (|AppParenTupleArg|_|) e =
-    match e with
-    | AppSingleParenArg (a, Paren (lpr, Tuple (ts, tr), rpr, pr)) -> Some(a, lpr, ts, tr, rpr, pr)
-    | _ -> None
-
-let (|AppParenSingleArg|_|) e =
-    match e with
-    | AppSingleParenArg (a, Paren (lpr, p, rpr, pr)) -> Some(a, lpr, p, rpr, pr)
-    | _ -> None
-
-let (|AppParenArg|_|) e =
-    match e with
-    | AppParenTupleArg t -> Choice1Of2 t |> Some
-    | AppParenSingleArg s -> Choice2Of2 s |> Some
-    | _ -> None
-
 let (|StroustrupStyleExpr|_|) (isStroustrupStyleEnabled: bool) (e: SynExpr) =
     if not isStroustrupStyleEnabled then
         None