From ac8a8cc2f9e6b0b42c50c78c71741a4baaf71fcd Mon Sep 17 00:00:00 2001 From: Amy Wang Date: Wed, 30 Oct 2024 17:22:41 -0400 Subject: [PATCH 1/2] add is not none --- gcsfs/core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcsfs/core.py b/gcsfs/core.py index 6fd05eae..73dbcebd 100644 --- a/gcsfs/core.py +++ b/gcsfs/core.py @@ -285,7 +285,7 @@ def __init__( version_aware=False, **kwargs, ): - if cache_timeout: + if cache_timeout is not None: kwargs["listings_expiry_time"] = cache_timeout super().__init__( self, From dfc1fe894358672434d0a58ee855b0df59747540 Mon Sep 17 00:00:00 2001 From: Amy Wang Date: Thu, 31 Oct 2024 12:36:17 -0400 Subject: [PATCH 2/2] test --- gcsfs/tests/test_core.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gcsfs/tests/test_core.py b/gcsfs/tests/test_core.py index 28f1a1d6..2a0b4c0c 100644 --- a/gcsfs/tests/test_core.py +++ b/gcsfs/tests/test_core.py @@ -1428,6 +1428,8 @@ def test_expiry_keyword(): assert gcs.dircache.listings_expiry_time == 1 gcs = GCSFileSystem(cache_timeout=1, token="anon") assert gcs.dircache.listings_expiry_time == 1 + gcs = GCSFileSystem(cache_timeout=0, token="anon") + assert gcs.dircache.listings_expiry_time == 0 def test_copy_cache_invalidated(gcs):