Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD support #29

Open
mfyuce opened this issue Jun 28, 2018 · 7 comments
Open

FreeBSD support #29

mfyuce opened this issue Jun 28, 2018 · 7 comments

Comments

@mfyuce
Copy link

mfyuce commented Jun 28, 2018

This library can easily support FreeBSD, I think. Waht do you say?

@benjaoming
Copy link
Collaborator

Thanks for asking

Yes, definitely -- someone (with FreeBSD!) is definitely encouraged to pick up this PR... #23

(feel welcome to supersede the PR with your own branch)

@rgeorgia
Copy link

Just forked this repo. I'll do this. Not to "up" on nose, but I'll learn. I'll add support for the major BSDs.

@rgeorgia
Copy link

rgeorgia commented Mar 20, 2022

Excuse my ignorance. Not sure if this is the platform for questions and clarification. I have ifcfg working with FreeBSD and NetBSD (there's a little cliche with OpenBSD). I know almost nothing about nose. If I create a venv with python3.10 nostetests fail with a traceback.

File "/usr/home/rgeorgia/workspace/python_projects/python-ifcfg/venv/lib/python3.10/site-packages/nose/suite.py", line 106, in _set_tests if isinstance(tests, collections.Callable) and not is_suite: AttributeError: module 'collections' has no attribute 'Callable'

All tests pass with python3.8 and python3.9. The tox.ini file has python3.8 as the max version. Are we staying with python3.8?

@benjaoming
Copy link
Collaborator

This sounds more like a Python 3.10 issue that should be fixed.

@benjaoming
Copy link
Collaborator

It seems like collections.abc.Callable would work in all Python versions, maybe you can check to see if it does on Python 3.10, too?

@rgeorgia
Copy link

Will do! Once I finish the tests (which include learning about nose) I just issue a pull request, correct? I forked the project and created a branch called freebsd.

@benjaoming
Copy link
Collaborator

Yes, I'm here to do a new release whenever needed, and @ftao is maybe also on the line :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants