Skip to content
This repository has been archived by the owner on Jun 9, 2022. It is now read-only.

Vertical Space in demos #47

Open
fedorinoGore opened this issue Oct 11, 2015 · 4 comments
Open

Vertical Space in demos #47

fedorinoGore opened this issue Oct 11, 2015 · 4 comments

Comments

@fedorinoGore
Copy link

It looks like all demos are showing that the library has some kind of troubles with vertical space adjustment. All of them are scrollable far beyond any visible content, especially in vertical direction.
Is it possible to do something with that?

@r007
Copy link

r007 commented Oct 11, 2015

It's because visibility of #flowedContent and #fixedContent is set to hidden, technically, they're not completely hidden. They still take space, that's why your page is scrollable far beyond. If you want to fix this issue, simply replace in css file visibility: hidden; on display: none; like that:

#flowedContent, #fixedContent {
    display: none;
}

P.S. I'm not a FTLabs developer, just wanted to help.

@georgecrawford
Copy link
Contributor

Thanks Sergey, I'd never noticed this.

Would you care to open a PR to fix this?

George


George Crawford
Senior Developer, Financial Times

+44 (0)752 567 9717
Number One Southwark Bridge,
London SE1 9HL

On 11 Oct 2015, at 18:14, Sergey Monin [email protected] wrote:

It's because visibility of #flowedContent and #fixedContent is set to hidden, technically, they're not completely hidden. They still take space, that's why your page is scrollable far beyond. If you want to fix this issue, simply replace in css file visibility: hidden; on display: none; like that:

#flowedContent, #fixedContent {
display: none;
}
P.S. I'm not a FTLabs developer, just wanted to help.


Reply to this email directly or view it on GitHub.


This email was sent by a company owned by Pearson plc, registered office at
80 Strand, London WC2R 0RL. Registered in England and Wales with company
number 53723.

@r007
Copy link

r007 commented Oct 11, 2015

Okay, I'll open a bit later.

@r007
Copy link

r007 commented Oct 12, 2015

#50 #49 Fixed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants