Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return "/" instead NIL #44

Open
C-Entropy opened this issue Mar 5, 2021 · 10 comments
Open

Return "/" instead NIL #44

C-Entropy opened this issue Mar 5, 2021 · 10 comments

Comments

@C-Entropy
Copy link

C-Entropy commented Mar 5, 2021

(use-package :quri)
(defparameter *uri* (uri "http://www.ics.uci.edu"))
(uri-path *uri*)==>NIL;; "/" should be better.
@C-Entropy C-Entropy changed the title Return " Return "/" instead NIL Mar 5, 2021
@svetlyak40wt
Copy link

I think this will be consistent with behaviour of browsers.

@Ambrevar
Copy link
Collaborator

Ambrevar commented Mar 5, 2021

http://www.ics.uci.edu/ is a different URI for which the path is /. Is there a use case for which we would still want to return a NIL path?

@C-Entropy
Copy link
Author

C-Entropy commented Mar 5, 2021

I have not seen this kind of example yet. But return NIL does cause error in both woo and wookie, see it here.
(Since firefox will just send http://www.ics.uci.edu instead of http://www.ics.uci.edu/ and I believe most people will just simply type http://www.ics.uci.edu )
More research in other case may be needed.
Maybe there are some cases that should return NIL, but I think in most case "/" should be returned when request like http://www.ics.uci.edu.

@Ambrevar
Copy link
Collaborator

Ambrevar commented Mar 5, 2021 via email

@C-Entropy
Copy link
Author

C-Entropy commented Mar 5, 2021

I think so, but it may need to be specified out specially. So the developer who use quri know this. And then wookie and woo and weblocks and others may need to change some code too.
Maybe better check the source code for why ever a NIL is returned

@Ambrevar
Copy link
Collaborator

Ambrevar commented Mar 5, 2021 via email

@C-Entropy
Copy link
Author

C-Entropy commented Mar 5, 2021

And documention too. It's very likely that pepole may not be aware of that(like me).

Maybe better check the source code for why ever a NIL is returned.

@Ambrevar
Copy link
Collaborator

Ambrevar commented Mar 6, 2021

@C-Entropy @svetlyak40wt Please see #45.

@C-Entropy
Copy link
Author

Sorry I can't tell about the code itself much.(I'm just a new hand:) ). But I'm happy to help with opening issue at wookie once you make progress.

@swapneils
Copy link

This issue was resolved by #60, correct?
I'm canvassing the available frameworks for a planned web app, and the issue seemed to propagate up into Woo, which makes it relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants