Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM inputs don't handle ref correctly #79

Closed
awkay opened this issue Nov 28, 2017 · 2 comments
Closed

DOM inputs don't handle ref correctly #79

awkay opened this issue Nov 28, 2017 · 2 comments
Assignees
@awkay

Comments

@awkay
Copy link
Member

awkay commented Nov 28, 2017 •
edited
Loading

They are still assuming the ref will be a string, which has been deprecated. This needs to be fixed soonish.
@awkay awkay self-assigned this Nov 28, 2017
@awkay awkay changed the title Om Next form inputs don't handle ref correctly DOM inputs don't handle ref correctly Dec 3, 2017
@awkay
Copy link
Member Author

awkay commented Dec 20, 2017

So it looks like the legacy DOM code I pulled from Om Next was doing a workaround for a bug in React. See r0man/sablono#148. I've change the code so that Fulcro's default is to generate the raw React components.

As insurance against this breaking people, I've made it so that if you set the JVM system property -DwrappedInputs=true then it will use the Om Next style wrapped inputs (input, textarea, option, and select); otherwise they will be the raw React elements that behave according to the React documentation.

@awkay awkay closed this as completed Dec 20, 2017
@awkay
Copy link
Member Author

awkay commented Dec 22, 2017

I changed this to keep the Om Next behavior as defaults, since we;re working on an RC. I switched the option logic, and changed the setting to -DrawInputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awkay awkay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@awkay