Changing to the mill build system #48

nh13 · 2019-05-27T22:14:38Z

Note: this isn't ready until:

mill is updated to output XML scoverage reports (Scoverage can output an XML report com-lihaoyi/mill#618)
travis-ci is able to pass
we have tested mill with publishing to sonatype

- code coverage - sonatype: http://www.lihaoyi.com/mill/page/common-project-layouts.html#publishing - name the output assembly JAR

This changes the build system to mill. Also: * remove the dependency badge since it no longer works

codecov-io · 2019-06-11T17:19:00Z

Codecov Report

Merging #48 into master will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   93.43%   93.78%   +0.34%     
==========================================
  Files          23       23              
  Lines         823      820       -3     
  Branches      122       70      -52     
==========================================
  Hits          769      769              
+ Misses         54       51       -3

Impacted Files	Coverage Δ
.../com/fulcrumgenomics/commons/util/StringUtil.scala	`100% <ø> (ø)`
...m/fulcrumgenomics/commons/io/AsyncStreamSink.scala	`90.9% <ø> (ø)`
...com/fulcrumgenomics/commons/collection/BiMap.scala	`100% <ø> (ø)`
...ommons/src/com/fulcrumgenomics/commons/io/Io.scala	`90.47% <ø> (ø)`
.../fulcrumgenomics/commons/async/AsyncIterator.scala	`100% <ø> (ø)`
...lcrumgenomics/commons/reflect/ReflectionUtil.scala	`92% <ø> (ø)`
...umgenomics/commons/reflect/ReflectiveBuilder.scala	`90.32% <ø> (ø)`
...omics/commons/collection/SelfClosingIterator.scala	`100% <ø> (ø)`
.../fulcrumgenomics/commons/util/NumericCounter.scala	`97.5% <ø> (ø)`
...ns/src/com/fulcrumgenomics/commons/io/Writer.scala	`0% <ø> (ø)`
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3087de3...f36be31. Read the comment docs.

jacarey · 2019-06-11T17:33:02Z

build.sc

+
+object commons extends ScalaModule with ScoverageModule with PublishModule {
+  def artifactName = "commons"
+  def gitHash = Process("git rev-parse --short HEAD").lineStream.head


I think you can avoid using Process and instead use ammonite os.proc

tfenne

A few questions and comments.

tfenne · 2019-06-13T20:37:33Z

.travis.yml

 after_success:
 - codecov
 - test "$TRAVIS_REPO_SLUG" == 'fulcrumgenomics/commons' && test "$TRAVIS_PULL_REQUEST"
-  == 'false' && test "$TRAVIS_BRANCH" == 'master' && sbt +publish
+  == 'false' && test "$TRAVIS_BRANCH" == 'master' && mill mill.scalalib.PublishModule/publishAll "${SONATYPE_USERNAME}:${SONATYPE_PASSWORD}" __.publishArtifacts --release true


This is a little cumbersome. Is there a way to put some of this line into the build file so that the command is closer to mill publishAll? Thinking about when we're doing official releases and doing this by hand.

Also, is this doing cross-builds?

tfenne · 2019-06-13T20:38:27Z

README.md

@@ -3,7 +3,6 @@
 [![Code Review](https://api.codacy.com/project/badge/grade/52e1d786d9784c7192fae2f8e853fa34)](https://www.codacy.com/app/contact_32/commons)
 [![Maven Central](https://maven-badges.herokuapp.com/maven-central/com.fulcrumgenomics/commons_2.11/badge.svg)](https://maven-badges.herokuapp.com/maven-central/com.fulcrumgenomics/commons_2.11)
 [![Javadocs](http://javadoc.io/badge/com.fulcrumgenomics/commons_2.12.svg)](http://javadoc.io/doc/com.fulcrumgenomics/commons_2.12)
-[![Dependency Status](https://www.versioneye.com/user/projects/56b2d2d593b95a003c714340/badge.svg)](https://www.versioneye.com/user/projects/56b2d2d593b95a003c714340#dialog_dependency_badge)


Could we also add a little to the README about how to build the project, so how to get the minimum version of mill and what the command is to compile/test/build jar? Perhaps how to publish locally?

We should also think about how one gets setup in IntelliJ since IntelliJ doesn't (yet) understand mill build files.

mill mill.scalalib.GenIdea/idea;

tfenne · 2019-06-13T20:39:02Z

build.sc

+  def scoverageVersion = "1.3.1"
+  def scalacOptions = Seq("-target:jvm-1.8", "-deprecation", "-unchecked")
+
+  // TODO: start year (2015)


Can we resolve these TODOs?

I could use some help 👍

tfenne · 2019-06-13T20:40:47Z

build.sc

+import scala.sys.process.Process
+
+object commons extends ScalaModule with ScoverageModule with PublishModule {
+  def artifactName = "commons"


Could we do something like getClass.getSimpleName here to standardize object == artifact name? Or do we want to embed the version name here?

tfenne · 2019-06-13T20:41:39Z

build.sc

+object commons extends ScalaModule with ScoverageModule with PublishModule {
+  def artifactName = "commons"
+  def gitHash = os.proc("git", "rev-parse", "--short", "HEAD").call().out.trim
+  def publishVersion = s"0.8.0-${gitHash}-SNAPSHOT"


I wonder if there's an easy way to pass custom params to a mill build such that we could define the version as if (release) "0.8.0" else (s"....")

tfenne · 2019-06-13T20:42:14Z

build.sc

+  def artifactName = "commons"
+  def gitHash = os.proc("git", "rev-parse", "--short", "HEAD").call().out.trim
+  def publishVersion = s"0.8.0-${gitHash}-SNAPSHOT"
+  def scalaVersion = "2.12.8"


So do we lose cross-building? That seems less than ideal.

Ah yes, I'll want to do add that support. Mill has facilities to do this http://www.lihaoyi.com/mill/page/cross-builds.html

tfenne · 2019-06-13T20:44:54Z

commons/test/src/com/fulcrumgenomics/commons/io/AsyncStreamSinkTest.scala

@@ -35,7 +35,7 @@ import scala.collection.mutable
  */
 class AsyncStreamSinkTest extends UnitSpec {
  "AsyncStreamSink" should "capture all the output" in {
-    val file = Paths.get("src/test/resources/com/fulcrumgenomics/commons/io/async-stream-sink-test.txt")
+    val file = Paths.get("commons/test/resources/com/fulcrumgenomics/commons/io/async-stream-sink-test.txt")


I'm a bit surprised by this. Does mill require even for single-module builds that the main and test sources are within a module directory?

http://www.lihaoyi.com/mill/page/common-project-layouts.html

nh13 · 2019-06-13T21:42:36Z

@tfenne I'll address your feedback, but I added a few comments for your future reading.

This was referenced May 27, 2019

WIP: Example of converting to using mill for building. #26

Closed

Change paths in coverage tests for sbt layout #47

Closed

nh13 added 7 commits June 11, 2019 09:32

Example of converting to using mill for building.

bada3db

Needs:

4f4a717

- code coverage - sonatype: http://www.lihaoyi.com/mill/page/common-project-layouts.html#publishing - name the output assembly JAR

WIP: scoverage

f92d76f

Separate scoverage and tests

738a5c0

Change to the preferred mill scala layout

d30df69

This changes the build system to mill. Also: * remove the dependency badge since it no longer works

bump

b0c3d83

fixup travis?

6bceea9

nh13 force-pushed the nh_mill_build branch from 86f4c14 to 6bceea9 Compare June 11, 2019 16:47

nh13 added 7 commits June 11, 2019 09:56

travis!

a014099

try again

4d710ef

one more try, let's do it again, aw yeah

7074359

do not cache mill plz

b6c4f4a

again

68b146b

got it

34e4f56

pray I do not alter the deal

040acb8

jacarey reviewed Jun 11, 2019

View reviewed changes

nh13 added 2 commits June 11, 2019 11:04

use os.proc instead of Process

1cf72a9

version should be 0.8.0

f36be31

nh13 marked this pull request as ready for review June 11, 2019 18:08

nh13 assigned tfenne Jun 11, 2019

jacarey approved these changes Jun 11, 2019

View reviewed changes

tfenne requested changes Jun 13, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changing to the mill build system #48

Changing to the mill build system #48

nh13 commented May 27, 2019 •

edited

Loading

codecov-io commented Jun 11, 2019 •

edited

Loading

jacarey Jun 11, 2019

tfenne left a comment

tfenne Jun 13, 2019

tfenne Jun 13, 2019

tfenne Jun 13, 2019

tfenne Jun 13, 2019

nh13 Jun 13, 2019

tfenne Jun 13, 2019

nh13 Jun 13, 2019

tfenne Jun 13, 2019

tfenne Jun 13, 2019

tfenne Jun 13, 2019

nh13 Jun 13, 2019

tfenne Jun 13, 2019

nh13 Jun 13, 2019

nh13 commented Jun 13, 2019

Changing to the mill build system #48

Are you sure you want to change the base?

Changing to the mill build system #48

Conversation

nh13 commented May 27, 2019 • edited Loading

codecov-io commented Jun 11, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

tfenne left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nh13 commented Jun 13, 2019

nh13 commented May 27, 2019 •

edited

Loading

codecov-io commented Jun 11, 2019 •

edited

Loading