Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error when the sample barcode lengths in the meta do not match the barcode lengths in the read structure #31

Open
nh13 opened this issue Jun 26, 2023 · 2 comments · May be fixed by #44
Open

Better error when the sample barcode lengths in the meta do not match the barcode lengths in the read structure #31

nh13 opened this issue Jun 26, 2023 · 2 comments · May be fixed by #44
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nh13
Copy link
Member

nh13 commented Jun 26, 2023 •
edited
Loading 

[2023-06-26T21:00:03Z INFO  fqtk::commands::demux] Created sample and unmatched writers.
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `40`,
 right: `60`: observed_bases: 40, expected_bases: 60', src/lib/barcode_matching.rs:74:9
@nh13 nh13 added enhancement New feature or request good first issue Good for newcomers labels Jun 26, 2023
@brendes
Copy link

brendes commented Feb 27, 2024

By "better error" do you mean simply make it use plainer/more obvious language for the end user, or something more?

@nh13
Copy link
Member Author

nh13 commented Feb 27, 2024

Exactly, provide an error message and perhaps even suggestion that does not require inspecting the code but provides something actionable to the end-user.

TimD1 added a commit that referenced this issue Jul 9, 2024
@TimD1
feat: better error message when barcode length differs from expected
3392552 
 - fixes #31, error message is now more clear
@TimD1 TimD1 linked a pull request Jul 9, 2024 that will close this issue
Open
TimD1 added a commit that referenced this issue Jul 10, 2024
@TimD1
feat: better error message when barcode length differs from expected
745cdb8 
 - barcode bases and lengths (actual and expected) and sample name are printed
 - fixes #31 by passing `Sample` to `count_mismatches()` instead of barcode string
 - all `count_mismatches()` tests updated to match new signature
 - minor miscellaneous comment typos fixed as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: better error message when barcode length differs from expected fulcrumgenomics/fqtk
2 participants
@nh13 @brendes