Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a post-init check to PrimerPair to verify that the pair's amplicon and sequence have the same length #77

Open
msto opened this issue Nov 6, 2024 · 1 comment
Open

Add a post-init check to PrimerPair to verify that the pair's amplicon and sequence have the same length #77

msto opened this issue Nov 6, 2024 · 1 comment
Assignees
@tfenne

Comments

@msto
Copy link
Collaborator

msto commented Nov 6, 2024

No description provided.

@msto
Copy link
Collaborator Author

msto commented Nov 7, 2024

Note: I have recently discovered that such a check exists, but it's implemented on OligoLike, which is an abstract base class. It was a bit surprising to me to discover concrete functionality implemented in an ABC.

I think as part of the planned deprecation of OligoLike (see #57 and related recent slack discussion12), it would be sensible to move this functionality into PrimerPair's post-init checks.

Footnotes

  1. https://fulcrumgenomics.slack.com/archives/C07FD0P14E9/p1730826346994899?thread_ts=1730816523.701149&cid=C07FD0P14E9 ↩

  2. https://fulcrumgenomics.slack.com/archives/C07FD0P14E9/p1727880849423929 ↩

@msto msto mentioned this issue Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tfenne tfenne

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msto @tfenne