Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some CI checks for TypeScript type definitions #146

Open
luser opened this issue Jun 13, 2022 · 0 comments
Open

Add some CI checks for TypeScript type definitions #146

luser opened this issue Jun 13, 2022 · 0 comments

Comments

@luser
Copy link
Contributor

luser commented Jun 13, 2022

Our TypeScript type definitions in this repository are hand-authored and because the SDK itself is not written in TypeScript it's possible for us to ship things that tsc won't accept. #144 is an example of one such thing. I asked for more details from the author of that PR, because I suspect that there's also a TypeScript version / configuration angle to this.

We should have some checks in this repo's CI to validate the TS types, ideally against a matrix of TS versions. If configuration matters, then doing so in the most-strict configuration possible would be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant