New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect use of xmlns "xlink" in img tag #57

Open

liamwhite opened this issue Mar 19, 2021 · 0 comments

Labels

bug

liamwhite commented Mar 19, 2021

Was curious why some user avatars were not rendering. That might be intentional, but this definitely isn't:

philomena/lib/philomena_web/views/user_attribution_view.ex

Lines 45 to 51 in a2e79c8

    
           def anonymous_avatar(_name, class \\ "avatar--100px") do 
        
             class = Enum.join(["image-constrained", class], " ") 
        
             content_tag :div, class: class do 
        
               raw("<img xlink:href=\"/images/no_avatar.svg\" src=\"/images/no_avatar.svg\">") 
        
             end 
        
           end

liamwhite added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment