Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Detected #7

Open
davisbradleyj opened this issue Nov 30, 2022 · 3 comments
Open

User Detected #7

davisbradleyj opened this issue Nov 30, 2022 · 3 comments

Comments

@davisbradleyj
Copy link
Collaborator

Summary of Questions for Data Layer Review

user_data.user_country - This can be an optional field

@dirkkelly
Copy link

dirkkelly commented Jan 3, 2023

Hi @davisbradleyj and a happy new year.

I have begun implementation and have a question about page_data being reset with the user_detected call

image

If we implement in this manner we get the following stack trace.
image
image
image

The detect user method clears out the page data before the history change triggered by page_view of the page load completed. If we don't include the page_data reset in user detected, eg:

image

Then the following stack trace occurs, which means the page_load_completed event contains the relevant page data.

image
image
image

Am I misunderstanding the process here, do we only need the page_data for the original page_load_started call?

Additionally I noticed that page_load_staretd sets the user_type where as user_detected sets the type, are both meant to be present or just one?

Cheers,
Dirk

@davisbradleyj
Copy link
Collaborator Author

Hi @dirkkelly,

We should probably not be clearing the page_data object with User Detected, as that information should be appended within the user_data object. I can have that line removed from the data layer today.

In the event that there is no User Detected event firing, you would still want some categorization of the user type, which is why we recommend a user_data type parameter be present in Page Load Started. If you expect User Detected to fire at all times, then yes, this may be redundant.

Best,
Brad

@dirkkelly
Copy link

Great thanks for clarifying @davisbradleyj 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants