Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search #37

Open
cade-egbert opened this issue Dec 16, 2022 · 5 comments
Open

search #37

cade-egbert opened this issue Dec 16, 2022 · 5 comments
Assignees

Comments

@cade-egbert
Copy link
Collaborator

I think we should update and add for if you click on location and the location performs the search

@jsmithckfi
Copy link
Collaborator

@cade-egbert test

@adeSDI adeSDI assigned adeSDI and blake-sdi and unassigned adeSDI Jan 3, 2023
@adeSDI adeSDI changed the title Search search Jan 3, 2023
@adeSDI adeSDI moved this to CK - Backlog in CKFI Recruitment Site DL Tasks Jan 3, 2023
@adeSDI adeSDI moved this from CK - Backlog to SDI - Ready for Validation in CKFI Recruitment Site DL Tasks Jan 3, 2023
@adeSDI adeSDI moved this from SDI - Ready for Validation to SDI Fix In Progress in CKFI Recruitment Site DL Tasks Jan 3, 2023
@adeSDI
Copy link

adeSDI commented Jan 9, 2023

@jsmithckfi Hey Jason, what are you thoughts on: updating and firing search event if the location is typed in? See Cade's comment above.

@jsmithckfi
Copy link
Collaborator

@adeSDI @cade-egbert, I believe this has been updated in the new search and sort features getting ready to deploy. I've tested in my dev, by searching 45503 and clicking the result.

Screen Shot 2023-01-09 at 3 18 03 PM

@adeSDI adeSDI moved this from SDI Fix In Progress to SDI - Ready for Validation in CKFI Recruitment Site DL Tasks Jan 17, 2023
@cade-egbert
Copy link
Collaborator Author

@jsmithckfi It seems like now we are only seeing 'search' fire when I select whatever location I searched for. Rather than when I type in the data. So now search and view_search_results fire at the same time. Would you like to only have one? Or does 'search' need to be updated for when a user types in a location? @adeSDI

@jsmithckfi
Copy link
Collaborator

@cade-egbert @adeSDI

I'm not sure. We can talk through on the Sprint today if that works.

@cade-egbert cade-egbert moved this from SDI - Ready for Validation to Validation Complete in CKFI Recruitment Site DL Tasks Jan 23, 2023
@adeSDI adeSDI moved this from Validated to Done in CKFI Recruitment Site DL Tasks Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants