-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actor.slicer function segmentation faults when using a int64 data type as input #851
Comments
I would like to work on this issue. |
is this issue still reproducible? @pjsjongsung ... The given code works perfectly fine for me |
Yes, I just reproduce it @ishankamboj. I am using macOS, maybe it is specific to the OS which would be strange. I tried with different python version and still the issue |
Ohh it works perfectly fine on windows. I think the issue is specific to linux/macOS. |
Could it be related to python version? I just tested on python 3.8 and 3.10 on windows and still get the fault. |
We both tested on different python version / OS and we still get segfault. only @ishankamboj do not get a segfault. Maybe he can share its full setup. (OS, python version, all packages versions / environment, etc...) |
I am using windows 11 as my OS and python version : 3.10.11 Following are the package versions: |
I reproduced the segmentation fault on both Ubuntu(WSL) and Windows 11. Ubuntu(WSL) mentions from fury.actor import slicer
import numpy as np
temp = np.ones((20, 20, 20)).astype(np.int64)
slicer(temp, np.eye(4))
print("this won't be printed") The last line won't be printed on Windows if tried. The code crashes.
People using Windows who run into this will certainly find it super confusing to debug. |
@robinroy03 is right ... The code ends abruptly and does not show segmentation fault on the terminal in windows. @skoudoro so to solve this we can just check if data array is passed as int64 and raise a |
Description
If fury.actor.slicer is passed a int64 type image, it throws a segmentation fault. Not a critical bug, but could be confusing to users if they encounter this.
Way to reproduce
Operating system is ubuntu 20.04. Tested with python 3.9 and 3.10
The text was updated successfully, but these errors were encountered: